github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7676] [MERGED] fix(sso): add better-call peerDeps #24388

New Issue
Closed
opened 2026-04-15 22:20:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:20:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7676
Author: @bytaesu
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @bytaesu

Base: canary ← Head: 2026-01-29/fix/sso-better-call

📝 Commits (3)

  • 64a4a78 chore: import from better-auth
  • 3654b00 fix: add better-call peerDeps
  • ef4df94 Merge branch 'canary' into 2026-01-29/fix/sso-better-call

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 packages/sso/package.json (+1 -0)
📝 packages/sso/src/saml-state.ts (+1 -1)

📄 Description

Note

This is working fine with bun or pnpm, but causes type issues for npm users.

Summary by cubic

Added better-call as a peer dependency in the SSO package to fix missing peer dependency issues. Updated SAML state to import APIError from better-auth/api for consistent error handling.

Written for commit ef4df942f3. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7676 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@bytaesu](https://github.com/bytaesu) **Base:** `canary` ← **Head:** `2026-01-29/fix/sso-better-call` --- ### 📝 Commits (3) - [`64a4a78`](https://github.com/better-auth/better-auth/commit/64a4a78b2adad8a50b7a5443296cf7dcb62ea97c) chore: import from better-auth - [`3654b00`](https://github.com/better-auth/better-auth/commit/3654b0077197bd216d7b248d76483093bb2345a0) fix: add better-call peerDeps - [`ef4df94`](https://github.com/better-auth/better-auth/commit/ef4df942f3f29c5f60773cebce3f5a74f7fd12fc) Merge branch 'canary' into 2026-01-29/fix/sso-better-call ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/package.json` (+1 -0) 📝 `packages/sso/src/saml-state.ts` (+1 -1) </details> ### 📄 Description > [!NOTE] > This is working fine with `bun` or `pnpm`, but causes type issues for `npm` users. - Closes https://github.com/better-auth/better-auth/issues/7219 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Added better-call as a peer dependency in the SSO package to fix missing peer dependency issues. Updated SAML state to import APIError from better-auth/api for consistent error handling. <sup>Written for commit ef4df942f3f29c5f60773cebce3f5a74f7fd12fc. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:20:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?