github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Using auth.api.signInEmail() doesn't return a proper Response with Two Factor plugin #243

New Issue
Closed
opened 2026-03-13 07:39:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 07:39:26 -05:00
Owner
Copy Link

Originally created by @FabienMotte on GitHub (Nov 18, 2024).

Describe the bug
When using auth.api.signInEmail({ body: {/* ... */, asResponse: true }) with the twoFactor plugin, only { twoFactorRedirect: true } is returned instead of a Response object (that includes headers).

29e6765759/packages/better-auth/src/plugins/two-factor/index.ts (L246-L253)

Version: 0.8.7-beta.3

Expected behavior
I would expect to get a Response object to be able to set the two factor cookie properly.

Originally created by @FabienMotte on GitHub (Nov 18, 2024). **Describe the bug** When using `auth.api.signInEmail({ body: {/* ... */, asResponse: true })` with the `twoFactor` plugin, only `{ twoFactorRedirect: true }` is returned instead of a `Response` object (that includes headers). https://github.com/better-auth/better-auth/blob/29e676575908f112f6b87dbcc93377b050b53fe5/packages/better-auth/src/plugins/two-factor/index.ts#L246-L253 Version: `0.8.7-beta.3` **Expected behavior** I would expect to get a `Response` object to be able to set the two factor cookie properly.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?