github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7522] [MERGED] docs: clarify wording in Admin Roles plugin section #24274

New Issue
Closed
opened 2026-04-15 22:16:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:16:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7522
Author: @Anjellyrika
Created: 1/21/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @Bekacru

Base: canary ← Head: docs/admin-plugin-custom-roles

📝 Commits (2)

  • f20ae0b docs: clarify wording in Admin Roles plugin section
  • d3fd712 docs: refine Admin Roles wording clarification with code snippet comment

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 docs/content/docs/plugins/admin.mdx (+4 -2)

📄 Description

This PR closes #7520.

Context

A new validation introduced in #6590 caused a breaking change in my project now that roles defined in adminRoles must also be defined in custom access control. The docs page for the Admin plugin (specifically Admin Roles) is now potentially misleading, and this PR adds a clarification reflecting the new requirement.

Changes

Reworded the text in admin.mdx that previously implied the possibility of defining custom roles in adminRoles without using custom access control.

Summary by cubic

Clarified the Admin Roles section in the Admin plugin docs. Added an inline snippet comment and updated the warning to make it clear that custom roles require custom access control (ac/roles), and that without it only admin and user exist.

Written for commit d3fd7123d8. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7522 **Author:** [@Anjellyrika](https://github.com/Anjellyrika) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `docs/admin-plugin-custom-roles` --- ### 📝 Commits (2) - [`f20ae0b`](https://github.com/better-auth/better-auth/commit/f20ae0bcbf97ab82a87093ea13e2e39c6f334e31) docs: clarify wording in Admin Roles plugin section - [`d3fd712`](https://github.com/better-auth/better-auth/commit/d3fd7123d85fb2cafb5691ca9ab0e752cea30d82) docs: refine Admin Roles wording clarification with code snippet comment ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/plugins/admin.mdx` (+4 -2) </details> ### 📄 Description This PR closes #7520. ### Context A new validation introduced in #6590 caused a breaking change in my project now that roles defined in `adminRoles` must also be defined in custom access control. The docs page for the Admin plugin (specifically Admin Roles) is now potentially misleading, and this PR adds a clarification reflecting the new requirement. ### Changes Reworded the text in `admin.mdx` that previously implied the possibility of defining custom roles in `adminRoles` without using custom access control. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Clarified the Admin Roles section in the Admin plugin docs. Added an inline snippet comment and updated the warning to make it clear that custom roles require custom access control (ac/roles), and that without it only admin and user exist. <sup>Written for commit d3fd7123d85fb2cafb5691ca9ab0e752cea30d82. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:16:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?