github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7521] [MERGED] fix(api): return Response for HTTP request contexts #24273

New Issue
Closed
opened 2026-04-15 22:16:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:16:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7521
Author: @gustavovalverde
Created: 1/21/2026
Status: ✅ Merged
Merged: 3/18/2026
Merged by: @himself65

Base: canary ← Head: fix/oauth-response-format

📝 Commits (1)

  • db4168d fix(api): return Response for HTTP request contexts

📊 Changes

2 files changed (+18 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/api/to-auth-endpoints.test.ts (+13 -0)
📝 packages/better-auth/src/api/to-auth-endpoints.ts (+5 -3)

📄 Description

Summary

Fixes OAuth/OIDC endpoints returning wrapped JSON responses for HTTP requests.

Problem

When endpoints receive an HTTP request context (with request object), they should return a proper Response object. Previously, if asResponse wasn't explicitly set, endpoints returned { response: {...} } which broke OAuth/OIDC spec compliance.

Solution

Detect HTTP request context by checking for context.request.url and automatically return a Response object, same as when asResponse: true is set.

const hasRequest = typeof context?.request?.url === "string";
const shouldReturnResponse = Boolean(context?.asResponse) || hasRequest;

Why this approach?

  • Generic: Works for ALL endpoints with HTTP request context, not just specific paths
  • Future-proof: No maintenance needed when adding new OAuth/OIDC/OpenID4VC endpoints
  • Complete: Handles both before hook early returns and final response construction
  • Tested: Includes regression test coverage

Fixes #7355

Summary by cubic

Return proper Response objects for OAuth/OIDC endpoints when called with an HTTP request context. This restores spec-compliant JSON bodies and Set-Cookie headers, and removes the wrapped { response: ... } output.

  • Bug Fixes
    • Detect HTTP request contexts via context.request instanceof Request and set shouldReturnResponse = context.asResponse ?? hasRequest.
    • Apply shouldReturnResponse across before-hook early returns, API error handling, and final response creation; add a regression test asserting Response type, JSON body, and Set-Cookie headers.

Written for commit db4168d236. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7521 **Author:** [@gustavovalverde](https://github.com/gustavovalverde) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 3/18/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/oauth-response-format` --- ### 📝 Commits (1) - [`db4168d`](https://github.com/better-auth/better-auth/commit/db4168d236ad54c8a48c4ab1a134d2f59ae619e6) fix(api): return Response for HTTP request contexts ### 📊 Changes **2 files changed** (+18 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/to-auth-endpoints.test.ts` (+13 -0) 📝 `packages/better-auth/src/api/to-auth-endpoints.ts` (+5 -3) </details> ### 📄 Description ## Summary Fixes OAuth/OIDC endpoints returning wrapped JSON responses for HTTP requests. ## Problem When endpoints receive an HTTP request context (with `request` object), they should return a proper `Response` object. Previously, if `asResponse` wasn't explicitly set, endpoints returned `{ response: {...} }` which broke OAuth/OIDC spec compliance. ## Solution Detect HTTP request context by checking for `context.request.url` and automatically return a `Response` object, same as when `asResponse: true` is set. ```typescript const hasRequest = typeof context?.request?.url === "string"; const shouldReturnResponse = Boolean(context?.asResponse) || hasRequest; ``` ## Why this approach? - **Generic**: Works for ALL endpoints with HTTP request context, not just specific paths - **Future-proof**: No maintenance needed when adding new OAuth/OIDC/OpenID4VC endpoints - **Complete**: Handles both before hook early returns and final response construction - **Tested**: Includes regression test coverage Fixes #7355 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Return proper Response objects for OAuth/OIDC endpoints when called with an HTTP request context. This restores spec-compliant JSON bodies and Set-Cookie headers, and removes the wrapped { response: ... } output. - **Bug Fixes** - Detect HTTP request contexts via context.request instanceof Request and set shouldReturnResponse = context.asResponse ?? hasRequest. - Apply shouldReturnResponse across before-hook early returns, API error handling, and final response creation; add a regression test asserting Response type, JSON body, and Set-Cookie headers. <sup>Written for commit db4168d236ad54c8a48c4ab1a134d2f59ae619e6. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:16:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24273
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?