github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7484] [MERGED] chore(one-tap): use npm type definitions #24248

New Issue
Closed
opened 2026-04-15 22:15:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:15:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7484
Author: @himself65
Created: 1/20/2026
Status: ✅ Merged
Merged: 1/20/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/01/19/one-tap

📝 Commits (1)

  • a55e8e7 chore(one-tap): use npm type definitions

📊 Changes

3 files changed (+25 additions, -17 deletions)

View changed files

📝 packages/better-auth/package.json (+1 -0)
📝 packages/better-auth/src/plugins/one-tap/client.ts (+1 -10)
📝 pnpm-lock.yaml (+23 -7)

📄 Description

Summary by cubic

Switched the One Tap client to use the official @types/google.accounts and removed the custom Window.google declaration. This improves type safety and editor hints with no runtime changes.

Written for commit a55e8e71c3. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7484 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/20/2026 **Status:** ✅ Merged **Merged:** 1/20/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/01/19/one-tap` --- ### 📝 Commits (1) - [`a55e8e7`](https://github.com/better-auth/better-auth/commit/a55e8e71c3f7e20d93feeb3a61ce262ec9eb22c9) chore(one-tap): use npm type definitions ### 📊 Changes **3 files changed** (+25 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/package.json` (+1 -0) 📝 `packages/better-auth/src/plugins/one-tap/client.ts` (+1 -10) 📝 `pnpm-lock.yaml` (+23 -7) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Switched the One Tap client to use the official @types/google.accounts and removed the custom Window.google declaration. This improves type safety and editor hints with no runtime changes. <sup>Written for commit a55e8e71c3f7e20d93feeb3a61ce262ec9eb22c9. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:15:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24248
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?