github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7248] [MERGED] chore: correct @vitest/coverage-istanbul in pnpm catalog #24072

New Issue
Closed
opened 2026-04-15 22:09:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:09:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7248
Author: @sukvvon
Created: 1/10/2026
Status: ✅ Merged
Merged: 1/10/2026
Merged by: @himself65

Base: canary ← Head: chore/vitest-coverage-istanbul

📝 Commits (2)

  • 4bb3d34 chore(pnpm-workspace): replace '@vitest/coverage-v8' with '@vitest/coverage-istanbul' in catalog
  • d3da321 Merge branch 'canary' into chore/vitest-coverage-istanbul

📊 Changes

3 files changed (+13 additions, -8 deletions)

View changed files

📝 package.json (+1 -1)
📝 pnpm-lock.yaml (+11 -6)
📝 pnpm-workspace.yaml (+1 -1)

📄 Description

Summary

  • Replace @vitest/coverage-v8 with @vitest/coverage-istanbul in pnpm-workspace catalog
  • Update root package.json to use catalog:vitest for version consistency

Context

The project uses Istanbul as the coverage provider (via --coverage.provider=istanbul in the root coverage script), but the pnpm-workspace catalog incorrectly had @vitest/coverage-v8 defined instead of @vitest/coverage-istanbul.

This was likely a leftover from the initial coverage configuration in #6339, where Istanbul was chosen but the catalog wasn't updated accordingly.

Summary by cubic

Switch coverage plugin in the pnpm workspace catalog from @vitest/coverage-v8 to @vitest/coverage-istanbul to match our Istanbul coverage setup. Update root package.json to use catalog:vitest for @vitest/coverage-istanbul to keep versions consistent across the workspace.

Written for commit d3da321c8b. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7248 **Author:** [@sukvvon](https://github.com/sukvvon) **Created:** 1/10/2026 **Status:** ✅ Merged **Merged:** 1/10/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `chore/vitest-coverage-istanbul` --- ### 📝 Commits (2) - [`4bb3d34`](https://github.com/better-auth/better-auth/commit/4bb3d349c83d7efd287d37143e287f27cdad5186) chore(pnpm-workspace): replace '@vitest/coverage-v8' with '@vitest/coverage-istanbul' in catalog - [`d3da321`](https://github.com/better-auth/better-auth/commit/d3da321c8bdea02c7c7fe371ca172c80e291a37e) Merge branch 'canary' into chore/vitest-coverage-istanbul ### 📊 Changes **3 files changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -1) 📝 `pnpm-lock.yaml` (+11 -6) 📝 `pnpm-workspace.yaml` (+1 -1) </details> ### 📄 Description ## Summary - Replace `@vitest/coverage-v8` with `@vitest/coverage-istanbul` in pnpm-workspace catalog - Update root `package.json` to use `catalog:vitest` for version consistency ## Context The project uses Istanbul as the coverage provider (via `--coverage.provider=istanbul` in the root coverage script), but the pnpm-workspace catalog incorrectly had `@vitest/coverage-v8` defined instead of `@vitest/coverage-istanbul`. This was likely a leftover from the initial coverage configuration in #6339, where Istanbul was chosen but the catalog wasn't updated accordingly. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Switch coverage plugin in the pnpm workspace catalog from @vitest/coverage-v8 to @vitest/coverage-istanbul to match our Istanbul coverage setup. Update root package.json to use catalog:vitest for @vitest/coverage-istanbul to keep versions consistent across the workspace. <sup>Written for commit d3da321c8bdea02c7c7fe371ca172c80e291a37e. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:09:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24072
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?