github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 06:16:18 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7214] [MERGED] docs(one-tap): add missing option and update to clearer description #24051

New Issue
Closed
opened 2026-04-15 22:09:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:09:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7214
Author: @bytaesu
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @Bekacru

Base: canary ← Head: 2026-01-09/docs/one-tap-options

📝 Commits (4)

  • 14e380a chore: clearer cancelOnTapOutside comment
  • 50a3af2 docs(one-tap): add missing uxMode option and update to clearer description
  • 2584fb0 Merge branch 'canary' into 2026-01-09/docs/one-tap-options
  • 426603c Update docs/content/docs/plugins/one-tap.mdx

📊 Changes

2 files changed (+14 additions, -11 deletions)

View changed files

📝 docs/content/docs/plugins/one-tap.mdx (+12 -11)
📝 packages/better-auth/src/plugins/one-tap/client.ts (+2 -0)

📄 Description

Note

When FedCM is enabled, the browser takes more control over the prompt behavior. This browser-controlled behavior may override or ignore certain JavaScript configuration options like cancelOnTapOutside since the FedCM prompt is rendered by the browser itself, not by JavaScript

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7214 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `2026-01-09/docs/one-tap-options` --- ### 📝 Commits (4) - [`14e380a`](https://github.com/better-auth/better-auth/commit/14e380a00e4b0f2192720dc52cd2790a239042d1) chore: clearer cancelOnTapOutside comment - [`50a3af2`](https://github.com/better-auth/better-auth/commit/50a3af27b1178f3dca9ac54958673cc329312f0f) docs(one-tap): add missing uxMode option and update to clearer description - [`2584fb0`](https://github.com/better-auth/better-auth/commit/2584fb0475972cb7005de5ef14c50e71c2c58707) Merge branch 'canary' into 2026-01-09/docs/one-tap-options - [`426603c`](https://github.com/better-auth/better-auth/commit/426603cbf4442954c6cd67a14966db04ae17d5db) Update docs/content/docs/plugins/one-tap.mdx ### 📊 Changes **2 files changed** (+14 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/plugins/one-tap.mdx` (+12 -11) 📝 `packages/better-auth/src/plugins/one-tap/client.ts` (+2 -0) </details> ### 📄 Description > [!NOTE] > When FedCM is enabled, the browser takes more control over the prompt behavior. This browser-controlled behavior may override or ignore certain JavaScript configuration options like cancelOnTapOutside since the FedCM prompt is rendered by the browser itself, not by JavaScript - Closes https://github.com/better-auth/better-auth/issues/7084 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:09:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24051
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?