github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 06:16:18 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7211] [MERGED] fix(one-tap): respect user dismiss actions in prompt retry logic #24049

New Issue
Closed
opened 2026-04-15 22:08:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:08:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7211
Author: @bytaesu
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @Bekacru

Base: canary ← Head: 2026-01-09/fix/one-tap-retry-behavior

📝 Commits (2)

  • b82d8f4 fix: respect user dismiss actions in prompt retry logic
  • 27a69ff fix: hoist noRetryReasons

📊 Changes

1 file changed (+19 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/one-tap/client.ts (+19 -0)

📄 Description

Summary by cubic

Stop auto-retrying the Google One Tap prompt when the user intentionally dismisses or skips it. Keeps exponential backoff retries for other cases and forwards the notification to onPromptNotification.

  • Bug Fixes
    • No retry on dismissed: credential_returned, cancel_called; skipped: user_cancel, tap_outside.
    • Continue retries with exponential backoff for other reasons.
    • Always pass prompt notifications to onPromptNotification.

Written for commit 27a69ff56a. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7211 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `2026-01-09/fix/one-tap-retry-behavior` --- ### 📝 Commits (2) - [`b82d8f4`](https://github.com/better-auth/better-auth/commit/b82d8f4b26b91d5a146dace06469e346186bf87a) fix: respect user dismiss actions in prompt retry logic - [`27a69ff`](https://github.com/better-auth/better-auth/commit/27a69ff56a296f6d300f2c79ab07ca7be7f7b4e9) fix: hoist noRetryReasons ### 📊 Changes **1 file changed** (+19 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/one-tap/client.ts` (+19 -0) </details> ### 📄 Description - Reference https://developers.google.com/identity/gsi/web/reference/js-reference <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Stop auto-retrying the Google One Tap prompt when the user intentionally dismisses or skips it. Keeps exponential backoff retries for other cases and forwards the notification to onPromptNotification. - **Bug Fixes** - No retry on dismissed: credential_returned, cancel_called; skipped: user_cancel, tap_outside. - Continue retries with exponential backoff for other reasons. - Always pass prompt notifications to onPromptNotification. <sup>Written for commit 27a69ff56a296f6d300f2c79ab07ca7be7f7b4e9. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:08:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24049
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?