github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7109] [MERGED] docs: improve sidebar content filtering and simplify CodeBlockTabs ren… #23983

New Issue
Closed
opened 2026-04-15 22:06:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:06:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7109
Author: @abdrhxyii
Created: 1/3/2026
Status: ✅ Merged
Merged: 1/3/2026
Merged by: @himself65

Base: canary ← Head: fix/docs-navigation-and-react-warnings

📝 Commits (2)

  • 30b8abb fix: improve sidebar content filtering and simplify CodeBlockTabs rendering
  • 7d81929 Merge branch 'canary' into fix/docs-navigation-and-react-warnings

📊 Changes

2 files changed (+9 additions, -7 deletions)

View changed files

📝 docs/app/docs/[[...slug]]/page.tsx (+1 -1)
📝 docs/components/sidebar-content.tsx (+8 -6)

📄 Description

Fix: Documentation Navigation and React DOM Warnings

  1. Fixed Next/Previous Page Navigation (Group Items Issue)

Problem: Group headers (e.g., "Social Sign-On") were included in the page tree navigation, causing the "Next Page" link to point to invalid/empty URLs

  1. Fixed React DOM Attribute Warnings

Problem: React was warning about non-standard props (groupId, persist) being passed to DOM elements

Summary by cubic

Fixes docs navigation by excluding group items from the page tree so next/previous links only target real pages. Also stops React DOM warnings by avoiding passing non-standard props through CodeBlockTabs.

  • Bug Fixes
    • Sidebar: filter out group headers and items without href when building the page tree.
    • CodeBlockTabs: render children directly to avoid spreading non-standard DOM attributes (e.g., groupId, persist).

Written for commit 7d819293a7. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7109 **Author:** [@abdrhxyii](https://github.com/abdrhxyii) **Created:** 1/3/2026 **Status:** ✅ Merged **Merged:** 1/3/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/docs-navigation-and-react-warnings` --- ### 📝 Commits (2) - [`30b8abb`](https://github.com/better-auth/better-auth/commit/30b8abba7353ca5987946e999ff5c323c505dcb0) fix: improve sidebar content filtering and simplify CodeBlockTabs rendering - [`7d81929`](https://github.com/better-auth/better-auth/commit/7d819293a7550c26a569f20506405517d19c1cae) Merge branch 'canary' into fix/docs-navigation-and-react-warnings ### 📊 Changes **2 files changed** (+9 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `docs/app/docs/[[...slug]]/page.tsx` (+1 -1) 📝 `docs/components/sidebar-content.tsx` (+8 -6) </details> ### 📄 Description ### Fix: Documentation Navigation and React DOM Warnings 1. Fixed Next/Previous Page Navigation (Group Items Issue) Problem: Group headers (e.g., "Social Sign-On") were included in the page tree navigation, causing the "Next Page" link to point to invalid/empty URLs 2. Fixed React DOM Attribute Warnings Problem: React was warning about non-standard props (groupId, persist) being passed to DOM elements <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes docs navigation by excluding group items from the page tree so next/previous links only target real pages. Also stops React DOM warnings by avoiding passing non-standard props through CodeBlockTabs. - **Bug Fixes** - Sidebar: filter out group headers and items without href when building the page tree. - CodeBlockTabs: render children directly to avoid spreading non-standard DOM attributes (e.g., groupId, persist). <sup>Written for commit 7d819293a7550c26a569f20506405517d19c1cae. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:06:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23983
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?