github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6942] [MERGED] chore(sso): remove Buffer usage #23881

New Issue
Closed
opened 2026-04-15 22:02:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:02:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6942
Author: @himself65
Created: 12/23/2025
Status: ✅ Merged
Merged: 12/23/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/12/23/no-buffer

📝 Commits (1)

  • 1cb7400 chore(sso): remove Buffer usage

📊 Changes

4 files changed (+69 additions, -16 deletions)

View changed files

📝 biome.json (+47 -1)
📝 packages/sso/package.json (+2 -1)
📝 packages/sso/src/routes/sso.ts (+7 -6)
📝 pnpm-lock.yaml (+13 -8)

📄 Description

Summary by cubic

Replaced Buffer usage in SSO SAML handlers with TextDecoder and @better-auth/utils/base64 for better cross-runtime compatibility. Added lint rules to block Buffer in src and updated dependencies.

  • Refactors

    • Decode SAMLResponse using base64.decode + TextDecoder instead of Buffer.from(...).toString("utf-8").
    • Enforce Biome rules to forbid Buffer type/global in packages//src/; tests are exempt.

  • Dependencies

    • Added @better-auth/utils@0.3.0 for base64 utilities.

Written for commit 1cb740050f. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6942 **Author:** [@himself65](https://github.com/himself65) **Created:** 12/23/2025 **Status:** ✅ Merged **Merged:** 12/23/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/12/23/no-buffer` --- ### 📝 Commits (1) - [`1cb7400`](https://github.com/better-auth/better-auth/commit/1cb740050f120c1737274d61d14478ed43efca72) chore(sso): remove `Buffer` usage ### 📊 Changes **4 files changed** (+69 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `biome.json` (+47 -1) 📝 `packages/sso/package.json` (+2 -1) 📝 `packages/sso/src/routes/sso.ts` (+7 -6) 📝 `pnpm-lock.yaml` (+13 -8) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Replaced Buffer usage in SSO SAML handlers with TextDecoder and @better-auth/utils/base64 for better cross-runtime compatibility. Added lint rules to block Buffer in src and updated dependencies. - **Refactors** - Decode SAMLResponse using base64.decode + TextDecoder instead of Buffer.from(...).toString("utf-8"). - Enforce Biome rules to forbid Buffer type/global in packages/**/src/**; tests are exempt. - **Dependencies** - Added @better-auth/utils@0.3.0 for base64 utilities. <sup>Written for commit 1cb740050f120c1737274d61d14478ed43efca72. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:02:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23881
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?