github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6921] [CLOSED] fix(session): add dev error logs when adapter join returns null user data #23868

New Issue
Closed
opened 2026-04-15 22:01:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:01:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6921
Author: @tavongamatikiti
Created: 12/21/2025
Status: ❌ Closed

Base: canary ← Head: fix/session-null-debugging

📝 Commits (1)

  • 21cfe54 fix(session): add dev error logs when adapter join returns null user data

📊 Changes

3 files changed (+86 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/api/routes/session-api.test.ts (+59 -0)
📝 packages/better-auth/src/api/routes/session.ts (+15 -0)
📝 packages/better-auth/src/db/internal-adapter.ts (+12 -1)

📄 Description

Summary by cubic

Added development-only error logs and stricter handling when a session adapter returns missing user join data. getSession now returns null and clears cookies in these cases, with clear debug messages for missing or expired sessions.

  • Bug Fixes
    • Internal adapter logs a clear error in development when user join data is missing and returns null.
    • getSession logs debug messages in development for null lookups and expired sessions; session cookie is cleared.
    • Added a test that simulates a broken adapter join and verifies getSession returns null.

Written for commit 21cfe541bf. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6921 **Author:** [@tavongamatikiti](https://github.com/tavongamatikiti) **Created:** 12/21/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/session-null-debugging` --- ### 📝 Commits (1) - [`21cfe54`](https://github.com/better-auth/better-auth/commit/21cfe541bf5c172ec563733dc79396a611c01003) fix(session): add dev error logs when adapter join returns null user data ### 📊 Changes **3 files changed** (+86 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/session-api.test.ts` (+59 -0) 📝 `packages/better-auth/src/api/routes/session.ts` (+15 -0) 📝 `packages/better-auth/src/db/internal-adapter.ts` (+12 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Added development-only error logs and stricter handling when a session adapter returns missing user join data. getSession now returns null and clears cookies in these cases, with clear debug messages for missing or expired sessions. - **Bug Fixes** - Internal adapter logs a clear error in development when user join data is missing and returns null. - getSession logs debug messages in development for null lookups and expired sessions; session cookie is cleared. - Added a test that simulates a broken adapter join and verifies getSession returns null. <sup>Written for commit 21cfe541bf5c172ec563733dc79396a611c01003. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:01:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?