github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6920] [MERGED] fix(stripe): update subscriptionId to use Stripe id #23867

New Issue
Closed
opened 2026-04-15 22:01:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:01:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6920
Author: @bytaesu
Created: 12/21/2025
Status: ✅ Merged
Merged: 12/21/2025
Merged by: @himself65

Base: canary ← Head: 2025-12-21/fix/stripe-subscription-id

📝 Commits (2)

  • 29df916 fix: update subscriptionId to use Stripe id only
  • d17791c chore: add stripe subscription spell ignore pattern

📊 Changes

2 files changed (+13 additions, -14 deletions)

View changed files

📝 .cspell.jsonc (+3 -0)
📝 packages/stripe/src/routes.ts (+10 -14)

📄 Description

Related to https://discord.com/channels/1288403910284935179/1451293763728314509

Summary by cubic

Switch subscriptionId to use Stripe subscription IDs (sub_...) for upgrade, cancel, and restore. This removes reliance on internal subscription IDs and makes lookups consistent.

  • Bug Fixes

    • Use stripeSubscriptionId for all subscription lookups in upgrade, cancel, and restore routes.
    • Clarify request schema descriptions to explicitly require Stripe subscription IDs.
    • Add cspell ignore pattern for sub_ IDs.

  • Migration

    • Clients must send the Stripe subscription ID (starts with sub_) in subscriptionId. Update any calls that previously used internal subscription IDs.

Written for commit d17791c9c6. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6920 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 12/21/2025 **Status:** ✅ Merged **Merged:** 12/21/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2025-12-21/fix/stripe-subscription-id` --- ### 📝 Commits (2) - [`29df916`](https://github.com/better-auth/better-auth/commit/29df9165fb31e30640e77e27958a607832d8eeab) fix: update subscriptionId to use Stripe id only - [`d17791c`](https://github.com/better-auth/better-auth/commit/d17791c9c6d7c134150ac42a3603df7154500cb6) chore: add stripe subscription spell ignore pattern ### 📊 Changes **2 files changed** (+13 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.cspell.jsonc` (+3 -0) 📝 `packages/stripe/src/routes.ts` (+10 -14) </details> ### 📄 Description Related to https://discord.com/channels/1288403910284935179/1451293763728314509 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Switch subscriptionId to use Stripe subscription IDs (sub_...) for upgrade, cancel, and restore. This removes reliance on internal subscription IDs and makes lookups consistent. - **Bug Fixes** - Use stripeSubscriptionId for all subscription lookups in upgrade, cancel, and restore routes. - Clarify request schema descriptions to explicitly require Stripe subscription IDs. - Add cspell ignore pattern for sub_ IDs. - **Migration** - Clients must send the Stripe subscription ID (starts with sub_) in subscriptionId. Update any calls that previously used internal subscription IDs. <sup>Written for commit d17791c9c6d7c134150ac42a3603df7154500cb6. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:01:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23867
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?