github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6804] [MERGED] feat(saml): normalize algorithm names before validation #23794

New Issue
Closed
opened 2026-04-15 21:59:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:59:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6804
Author: @Paola3stefania
Created: 12/16/2025
Status: ✅ Merged
Merged: 12/23/2025
Merged by: @himself65

Base: feat/saml-algorithm-allowlist ← Head: feat/saml-algorithm-normalization

📝 Commits (6)

  • de9b2c9 feat : normalize
  • c4a8f91 fix: update validateConfigAlgs
  • af251ae fix: test
  • 89946d2 backwards compat
  • 01845a7 make lint happy
  • 5073914 Merge branch 'feat/saml-algorithm-allowlist' into feat/saml-algorithm-normalization

📊 Changes

2 files changed (+117 additions, -21 deletions)

View changed files

📝 packages/sso/src/saml/algorithms.test.ts (+72 -2)
📝 packages/sso/src/saml/algorithms.ts (+45 -19)

📄 Description

Summary by cubic

Normalize SAML algorithm inputs by mapping common short forms (sha256, rsa-sha256, ecdsa-sha512, etc.) to their SAML URI equivalents. This is case-insensitive and applies to config values and allow-lists, so deprecation and allow-list checks work with short forms.

Written for commit 50739143dc. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6804 **Author:** [@Paola3stefania](https://github.com/Paola3stefania) **Created:** 12/16/2025 **Status:** ✅ Merged **Merged:** 12/23/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `feat/saml-algorithm-allowlist` ← **Head:** `feat/saml-algorithm-normalization` --- ### 📝 Commits (6) - [`de9b2c9`](https://github.com/better-auth/better-auth/commit/de9b2c9ffe8b8a07d8d113f9b37337ae2d8f6cee) feat : normalize - [`c4a8f91`](https://github.com/better-auth/better-auth/commit/c4a8f91ad7cef94277c6d8114b40019e34914b19) fix: update validateConfigAlgs - [`af251ae`](https://github.com/better-auth/better-auth/commit/af251ae3d685340e538ddc17e1300e97adfab76d) fix: test - [`89946d2`](https://github.com/better-auth/better-auth/commit/89946d2d76ee29f9dfe5e3251ee33315edace8ba) backwards compat - [`01845a7`](https://github.com/better-auth/better-auth/commit/01845a7fc4a8813a8da4eaff9da7d990a61a6e65) make lint happy - [`5073914`](https://github.com/better-auth/better-auth/commit/50739143dc22039433da1e6072c8e942a213a14c) Merge branch 'feat/saml-algorithm-allowlist' into feat/saml-algorithm-normalization ### 📊 Changes **2 files changed** (+117 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/saml/algorithms.test.ts` (+72 -2) 📝 `packages/sso/src/saml/algorithms.ts` (+45 -19) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Normalize SAML algorithm inputs by mapping common short forms (sha256, rsa-sha256, ecdsa-sha512, etc.) to their SAML URI equivalents. This is case-insensitive and applies to config values and allow-lists, so deprecation and allow-list checks work with short forms. <sup>Written for commit 50739143dc22039433da1e6072c8e942a213a14c. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:59:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23794
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?