github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6309] [MERGED] feat: lint dependencies #23483

New Issue
Closed
opened 2026-04-15 21:45:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:45:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6309
Author: @jonathansamines
Created: 11/25/2025
Status: ✅ Merged
Merged: 12/1/2025
Merged by: @Bekacru

Base: canary ← Head: feat/lint-dependencies

📝 Commits (10+)

  • fdbc4ff chore: configure knip linter
  • 68eb6e0 chore: configure exclusions for implicit dependencies
  • be28155 chore: use react catalogs to sync dependencies
  • eba5ddc chore(better-auth): remove unused files
  • b02c91a chore(better-auth): update reference to the correct file
  • 14b6b04 chore(cli): remove unused dependencies
  • 2264096 chore(core): remove unused dependencies
  • 565d8c0 chore(sso): remove unnecessary dependencies
  • a543f9b chore(expo): add undeclared dependencies
  • 647e518 chore(better-auth): remove unnecessary dependencies

📊 Changes

23 files changed (+440 additions, -403 deletions)

View changed files

📝 .github/workflows/ci.yml (+6 -0)
📝 demo/expo/package.json (+3 -3)
📝 demo/nextjs/package.json (+4 -4)
📝 demo/oidc-client/package.json (+4 -4)
📝 demo/stateless/package.json (+4 -4)
📝 docs/package.json (+4 -4)
➕ knip.jsonc (+101 -0)
📝 package.json (+2 -0)
📝 packages/better-auth/package.json (+4 -10)
➖ packages/better-auth/src/cookies/check-cookies.ts (+0 -23)
➖ packages/better-auth/src/plugins/oidc-provider/ui.ts (+0 -142)
📝 packages/better-auth/src/plugins/one-time-token/index.ts (+1 -1)
➖ packages/better-auth/src/utils/await-object.ts (+0 -13)
➖ packages/better-auth/src/utils/clone.ts (+0 -19)
➖ packages/better-auth/src/utils/ensure-utc.ts (+0 -13)
➖ packages/better-auth/src/utils/import-util.ts (+0 -3)
➖ packages/better-auth/src/utils/merger.ts (+0 -48)
📝 packages/cli/package.json (+1 -3)
📝 packages/core/package.json (+0 -2)
📝 packages/expo/package.json (+1 -0)

...and 3 more files

📄 Description

What is changing?
This PR is introduced dependencies linting via knip. The idea of this linter is to detect common issues in regards to dependency management:

  • Unused dependencies (Why have a dependency that is never loaded?)
  • Undeclared dependencies (It is fragile to load a dependency we don't declare ourselves)
  • Unused files (Why maintain code that is not used anywhere?)

Summary by cubic

Add Knip-based dependency linting across the monorepo and run it in CI. Clean up unused code and streamline dependencies to prevent drift and reduce bloat.

  • New Features

    • Add knip.jsonc with workspace rules and ignores for implicit deps/tests.
    • Add pnpm lint:dependencies and a CI job to run it.

  • Refactors

    • Remove unused better-auth files (cookie check, OIDC UI, legacy utils).
    • Standardize React 19 via pnpm catalog; update demos/docs and package refs.
    • Prune/move deps across packages (better-auth, cli, core, sso); add missing peer better-auth to expo; declare ms as a direct dep; fix one import path in one-time-token.

Written for commit a4ae7dbce8. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6309 **Author:** [@jonathansamines](https://github.com/jonathansamines) **Created:** 11/25/2025 **Status:** ✅ Merged **Merged:** 12/1/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `feat/lint-dependencies` --- ### 📝 Commits (10+) - [`fdbc4ff`](https://github.com/better-auth/better-auth/commit/fdbc4ffec21c9db6e9eefe91974bb38703e0a0b7) chore: configure knip linter - [`68eb6e0`](https://github.com/better-auth/better-auth/commit/68eb6e0fc8d633c8beb47930d6cdbcf9da773bf2) chore: configure exclusions for implicit dependencies - [`be28155`](https://github.com/better-auth/better-auth/commit/be281551cd39828d74fb741663e134768deacbaf) chore: use react catalogs to sync dependencies - [`eba5ddc`](https://github.com/better-auth/better-auth/commit/eba5ddcab9c34e11776039589fda5f4d8472ec6a) chore(better-auth): remove unused files - [`b02c91a`](https://github.com/better-auth/better-auth/commit/b02c91a9bb773e848bef4fc8332b3a5168c396f8) chore(better-auth): update reference to the correct file - [`14b6b04`](https://github.com/better-auth/better-auth/commit/14b6b046b68e71447a120a347b5488ec9dce8000) chore(cli): remove unused dependencies - [`2264096`](https://github.com/better-auth/better-auth/commit/22640965d860bfbe27aa7ebb0f30a1aa8c9ed903) chore(core): remove unused dependencies - [`565d8c0`](https://github.com/better-auth/better-auth/commit/565d8c09f2857506905fe81fc7f7f6392f1ca82a) chore(sso): remove unnecessary dependencies - [`a543f9b`](https://github.com/better-auth/better-auth/commit/a543f9b60d23b95c285adfd1464de4fea8f49ecc) chore(expo): add undeclared dependencies - [`647e518`](https://github.com/better-auth/better-auth/commit/647e518210acec66653da6883acc564c85579221) chore(better-auth): remove unnecessary dependencies ### 📊 Changes **23 files changed** (+440 additions, -403 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+6 -0) 📝 `demo/expo/package.json` (+3 -3) 📝 `demo/nextjs/package.json` (+4 -4) 📝 `demo/oidc-client/package.json` (+4 -4) 📝 `demo/stateless/package.json` (+4 -4) 📝 `docs/package.json` (+4 -4) ➕ `knip.jsonc` (+101 -0) 📝 `package.json` (+2 -0) 📝 `packages/better-auth/package.json` (+4 -10) ➖ `packages/better-auth/src/cookies/check-cookies.ts` (+0 -23) ➖ `packages/better-auth/src/plugins/oidc-provider/ui.ts` (+0 -142) 📝 `packages/better-auth/src/plugins/one-time-token/index.ts` (+1 -1) ➖ `packages/better-auth/src/utils/await-object.ts` (+0 -13) ➖ `packages/better-auth/src/utils/clone.ts` (+0 -19) ➖ `packages/better-auth/src/utils/ensure-utc.ts` (+0 -13) ➖ `packages/better-auth/src/utils/import-util.ts` (+0 -3) ➖ `packages/better-auth/src/utils/merger.ts` (+0 -48) 📝 `packages/cli/package.json` (+1 -3) 📝 `packages/core/package.json` (+0 -2) 📝 `packages/expo/package.json` (+1 -0) _...and 3 more files_ </details> ### 📄 Description **What is changing?** This PR is introduced dependencies linting via [knip](https://knip.dev/). The idea of this linter is to detect common issues in regards to dependency management: - Unused dependencies (Why have a dependency that is never loaded?) - Undeclared dependencies (It is fragile to load a dependency we don't declare ourselves) - Unused files (Why maintain code that is not used anywhere?) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Add Knip-based dependency linting across the monorepo and run it in CI. Clean up unused code and streamline dependencies to prevent drift and reduce bloat. - **New Features** - Add knip.jsonc with workspace rules and ignores for implicit deps/tests. - Add pnpm lint:dependencies and a CI job to run it. - **Refactors** - Remove unused better-auth files (cookie check, OIDC UI, legacy utils). - Standardize React 19 via pnpm catalog; update demos/docs and package refs. - Prune/move deps across packages (better-auth, cli, core, sso); add missing peer better-auth to expo; declare ms as a direct dep; fix one import path in one-time-token. <sup>Written for commit a4ae7dbce867273f362e6bfa3917a80e524a8d5a. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:45:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23483
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?