github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5894] [MERGED] fix(oauth2): fix user data not reflecting provider updates with overrideUserInfo #23204

New Issue
Closed
opened 2026-04-15 21:32:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:32:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5894
Author: @dandamian
Created: 11/11/2025
Status: ✅ Merged
Merged: 11/11/2025
Merged by: @himself65

Base: canary ← Head: fix/oauth2-override-info

📝 Commits (3)

  • c7b5247 fix(oauth2): fix user data not reflecting provider updates with overrideUserInfo
  • a264f8d Test case for user info override fix
  • ac9664c Use cookieCache instead of secondaryStorage in test

📊 Changes

2 files changed (+105 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/oauth2/link-account.test.ts (+104 -1)
📝 packages/better-auth/src/oauth2/link-account.ts (+1 -1)

📄 Description

When overrideUserInfo is enabled, updateUser() was called but its return value wasn't captured, causing sessions to be created with stale user data instead of the updated information from the OAuth provider.

Summary by cubic

Fixed OAuth sessions using stale user data when overrideUserInfo is enabled. We now assign the result of updateUser to the user object so sessions reflect provider updates on sign-in and account linking.

Written for commit ac9664c3b2. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5894 **Author:** [@dandamian](https://github.com/dandamian) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 11/11/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/oauth2-override-info` --- ### 📝 Commits (3) - [`c7b5247`](https://github.com/better-auth/better-auth/commit/c7b5247644b855a2dfb00eb851456662dd8df5c8) fix(oauth2): fix user data not reflecting provider updates with overrideUserInfo - [`a264f8d`](https://github.com/better-auth/better-auth/commit/a264f8d54fade3a4ecbcfd4915ba29b2a388b31e) Test case for user info override fix - [`ac9664c`](https://github.com/better-auth/better-auth/commit/ac9664c3b26449d2da631327b5ff8aeabe16e7ed) Use cookieCache instead of secondaryStorage in test ### 📊 Changes **2 files changed** (+105 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/oauth2/link-account.test.ts` (+104 -1) 📝 `packages/better-auth/src/oauth2/link-account.ts` (+1 -1) </details> ### 📄 Description When `overrideUserInfo` is enabled, `updateUser()` was called but its return value wasn't captured, causing sessions to be created with stale user data instead of the updated information from the OAuth provider. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed OAuth sessions using stale user data when overrideUserInfo is enabled. We now assign the result of updateUser to the user object so sessions reflect provider updates on sign-in and account linking. <sup>Written for commit ac9664c3b26449d2da631327b5ff8aeabe16e7ed. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:32:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23204
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?