github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5832] [MERGED] fix(db): postgres - explicitly define pg_catalog for gen_random_uuid() #23160

New Issue
Closed
opened 2026-04-15 21:31:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:31:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5832
Author: @mrl5
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @Bekacru

Base: canary ← Head: use-pg-catalog

📝 Commits (1)

  • 7e649eb fix(db): explicitly define pg_catalog for postgres gen_random_uuid()

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/db/get-migration.ts (+1 -1)

📄 Description

when #5809 was merged as 4ac3476642 it introduced a vulnerability marked as CVE-2018-1058. It's described in https://wiki.postgresql.org/wiki/A_Guide_to_CVE-2018-1058%3A_Protect_Your_Search_Path

The problem described in CVE-2018-1058 centers around the default
"public" schema and how PostgreSQL uses the search_path setting. The
ability to create objects with the same names in different schemas,
combined with how PostgreSQL searches for objects within schemas,
presents an opportunity for a user to modify the behavior of a query for
other users.

This vulnerability is not so much severe since Postgres 15 (https://www.postgresql.org/docs/release/15.0/ and https://pganalyze.com/blog/5mins-postgres-security-patch-releases-pgspot-pghostile#postgres-15-default-revoke-public-create-from-public-schema) due to:

The new default is one of the secure schema usage patterns that
Section 5.9.6 has recommended since the security release for
CVE-2018-1058. The change applies to new database clusters and to
newly-created databases in existing clusters. Upgrading a cluster or
restoring a database dump will preserve public's existing permissions.

That being said, it's a good thing to define pg_catalog schema explicity (even for postgres versions >=15) to have a additional security layer.

This vulnerability should be fixed before a release containing 4ac3476642 is created so that it couldn't be exploited "in the wild"

Summary by cubic

Use pg_catalog.gen_random_uuid() in Postgres migrations to prevent search_path hijacking (CVE-2018-1058) and ensure safe UUID defaults. Only affects Postgres; MySQL/MSSQL unchanged.

Written for commit 7e649eba5d. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5832 **Author:** [@mrl5](https://github.com/mrl5) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `use-pg-catalog` --- ### 📝 Commits (1) - [`7e649eb`](https://github.com/better-auth/better-auth/commit/7e649eba5dc091e43d489e0496c4fcf603a1dcba) fix(db): explicitly define pg_catalog for postgres gen_random_uuid() ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/get-migration.ts` (+1 -1) </details> ### 📄 Description when #5809 was merged as 4ac3476642efbd40a10536d3f36adb1fb6795e52 it introduced a vulnerability marked as CVE-2018-1058. It's described in https://wiki.postgresql.org/wiki/A_Guide_to_CVE-2018-1058%3A_Protect_Your_Search_Path > The problem described in CVE-2018-1058 centers around the default > "public" schema and how PostgreSQL uses the search_path setting. The > ability to create objects with the same names in different schemas, > combined with how PostgreSQL searches for objects within schemas, > presents an opportunity for a user to modify the behavior of a query for > other users. This vulnerability is not so much severe since Postgres 15 (https://www.postgresql.org/docs/release/15.0/ and https://pganalyze.com/blog/5mins-postgres-security-patch-releases-pgspot-pghostile#postgres-15-default-revoke-public-create-from-public-schema) due to: > The new default is one of the secure schema usage patterns that > Section 5.9.6 has recommended since the security release for > CVE-2018-1058. The change applies to new database clusters and to > newly-created databases in existing clusters. Upgrading a cluster or > restoring a database dump will preserve public's existing permissions. That being said, it's a good thing to define `pg_catalog` schema explicity (even for postgres versions >=15) to have a additional security layer. This vulnerability should be fixed before a release containing 4ac3476642efbd40a10536d3f36adb1fb6795e52 is created so that it couldn't be exploited "in the wild" <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Use pg_catalog.gen_random_uuid() in Postgres migrations to prevent search_path hijacking (CVE-2018-1058) and ensure safe UUID defaults. Only affects Postgres; MySQL/MSSQL unchanged. <sup>Written for commit 7e649eba5dc091e43d489e0496c4fcf603a1dcba. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:31:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23160
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?