github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5803] [CLOSED] Remove duplicate token endpoint declarations #23136

New Issue
Closed
opened 2026-04-15 21:30:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:30:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5803
Author: @lakbychance
Created: 11/6/2025
Status: ❌ Closed

Base: canary ← Head: remove-duplicate-tokenEndpoint-declarations

📝 Commits (10+)

📊 Changes

640 files changed (+37565 additions, -9859 deletions)

View changed files

➖ .github/workflows/branch-rules.yml (+0 -36)
📝 .github/workflows/ci.yml (+2 -2)
📝 .github/workflows/e2e.yml (+6 -5)
➖ .github/workflows/main-protect.yml (+0 -18)
📝 .github/workflows/preview.yml (+2 -2)
📝 .github/workflows/release.yml (+11 -6)
📝 CONTRIBUTING.md (+30 -6)
📝 README.md (+1 -1)
📝 biome.json (+4 -2)
➕ demo/expo-example/.env.example (+7 -0)
➕ demo/expo-example/.gitignore (+20 -0)
➕ demo/expo-example/README.md (+15 -0)
➕ demo/expo-example/app.config.ts (+55 -0)
➕ demo/expo-example/assets/bg-image.jpeg (+0 -0)
➕ demo/expo-example/assets/fonts/SpaceMono-Regular.ttf (+0 -0)
➕ demo/expo-example/assets/icon.png (+0 -0)
➕ demo/expo-example/assets/images/adaptive-icon.png (+0 -0)
➕ demo/expo-example/assets/images/favicon.png (+0 -0)
➕ demo/expo-example/assets/images/logo.png (+0 -0)
➕ demo/expo-example/assets/images/partial-react-logo.png (+0 -0)

...and 80 more files

📄 Description

Noticed that we are using single tokenEndpoint declarations in some social providers and duplicating in others. Wherever applicable, have manually gone through the providers and used one tokenEndpoint constant to remove code redundancy.

Summary by cubic

Adds an Expo example app and updates the Next.js demo with SSO support, while introducing docs endpoints for chat/analytics/support and streamlining CI/workflows and tooling.

  • New Features

    • New Expo example using Expo Router, SecureStore, and social providers (GitHub/Google).
    • Docs APIs for AI chat, analytics (events/conversations/feedback), and support; OG defaults added.
    • Next.js demo supports @better-auth/sso.

  • Refactors

    • Simplified GitHub workflows (removed branch-protection/branch-rules, updated actions/cache, pinned setup-node).
    • Next.js demo cleanup: Tailwind v4 class updates, removed three.js canvas effect and related deps.
    • Tooling/docs: CONTRIBUTING adds nvm/corepack guidance; stricter lint rules; expanded docker-compose DB services; blog layout and sorting improvements.

Written for commit e8c546ac57. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5803 **Author:** [@lakbychance](https://github.com/lakbychance) **Created:** 11/6/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `remove-duplicate-tokenEndpoint-declarations` --- ### 📝 Commits (10+) - [`7608d7f`](https://github.com/better-auth/better-auth/commit/7608d7f52975e7a55f32355af04829c089763e2b) chore: remove log - [`6bd551e`](https://github.com/better-auth/better-auth/commit/6bd551efde0ef3bd639f5897122365a0750c08e6) chore: release v1.3.20 - [`d52cbab`](https://github.com/better-auth/better-auth/commit/d52cbab069b62396c8e6640b4703d7a8b7f4ff66) chore: release v1.3.20 - [`0f5ccce`](https://github.com/better-auth/better-auth/commit/0f5ccce4cc45fa6ddb630521777605f3fe317d7a) chore: release v1.3.22 - [`fbde661`](https://github.com/better-auth/better-auth/commit/fbde661f44e878e218ddc0721b76cc63b3888024) chore: remove log - [`565fe8e`](https://github.com/better-auth/better-auth/commit/565fe8e37e95405fbc48bab1a56a01973a240770) chore: release v1.3.23 - [`8243189`](https://github.com/better-auth/better-auth/commit/82431899dc5bcdb95a9c0d624505dc0b2f43e8be) chore: typecheck using monorepo (#4920) - [`44d3f4e`](https://github.com/better-auth/better-auth/commit/44d3f4e7c801a2c418832fbe439a110c9fd4b530) refactor: move db schema to core (#4918) - [`9664b9a`](https://github.com/better-auth/better-auth/commit/9664b9a834a26f9735cc99bb6adf4f7e4751bd0f) feat: waku integration guide (#3990) - [`2852122`](https://github.com/better-auth/better-auth/commit/28521222bf7e2bc99051e87b5cfd13fc6a48fbbd) refactor: move mockLogger into the specific test file (#4931) ### 📊 Changes **640 files changed** (+37565 additions, -9859 deletions) <details> <summary>View changed files</summary> ➖ `.github/workflows/branch-rules.yml` (+0 -36) 📝 `.github/workflows/ci.yml` (+2 -2) 📝 `.github/workflows/e2e.yml` (+6 -5) ➖ `.github/workflows/main-protect.yml` (+0 -18) 📝 `.github/workflows/preview.yml` (+2 -2) 📝 `.github/workflows/release.yml` (+11 -6) 📝 `CONTRIBUTING.md` (+30 -6) 📝 `README.md` (+1 -1) 📝 `biome.json` (+4 -2) ➕ `demo/expo-example/.env.example` (+7 -0) ➕ `demo/expo-example/.gitignore` (+20 -0) ➕ `demo/expo-example/README.md` (+15 -0) ➕ `demo/expo-example/app.config.ts` (+55 -0) ➕ `demo/expo-example/assets/bg-image.jpeg` (+0 -0) ➕ `demo/expo-example/assets/fonts/SpaceMono-Regular.ttf` (+0 -0) ➕ `demo/expo-example/assets/icon.png` (+0 -0) ➕ `demo/expo-example/assets/images/adaptive-icon.png` (+0 -0) ➕ `demo/expo-example/assets/images/favicon.png` (+0 -0) ➕ `demo/expo-example/assets/images/logo.png` (+0 -0) ➕ `demo/expo-example/assets/images/partial-react-logo.png` (+0 -0) _...and 80 more files_ </details> ### 📄 Description Noticed that we are using single `tokenEndpoint` declarations in some social providers and duplicating in others. Wherever applicable, have manually gone through the providers and used one `tokenEndpoint` constant to remove code redundancy. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Adds an Expo example app and updates the Next.js demo with SSO support, while introducing docs endpoints for chat/analytics/support and streamlining CI/workflows and tooling. - New Features - New Expo example using Expo Router, SecureStore, and social providers (GitHub/Google). - Docs APIs for AI chat, analytics (events/conversations/feedback), and support; OG defaults added. - Next.js demo supports @better-auth/sso. - Refactors - Simplified GitHub workflows (removed branch-protection/branch-rules, updated actions/cache, pinned setup-node). - Next.js demo cleanup: Tailwind v4 class updates, removed three.js canvas effect and related deps. - Tooling/docs: CONTRIBUTING adds nvm/corepack guidance; stricter lint rules; expanded docker-compose DB services; blog layout and sorting improvements. <sup>Written for commit e8c546ac577a0c1d8606e0a4c8389e34bc3660e1. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:30:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23136
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?