github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5655] [MERGED] chore: use strict lint rules #23045

New Issue
Closed
opened 2026-04-15 21:26:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:26:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5655
Author: @himself65
Created: 10/28/2025
Status: ✅ Merged
Merged: 10/28/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/10/28/lint-rules

📝 Commits (1)

  • 7d772ac chore: use strict lint rules

📊 Changes

32 files changed (+64 additions, -64 deletions)

View changed files

📝 packages/better-auth/src/api/to-auth-endpoints.ts (+2 -2)
📝 packages/better-auth/src/client/vue/vue-store.ts (+1 -1)
📝 packages/core/src/social-providers/apple.ts (+2 -2)
📝 packages/core/src/social-providers/atlassian.ts (+2 -2)
📝 packages/core/src/social-providers/cognito.ts (+2 -2)
📝 packages/core/src/social-providers/discord.ts (+2 -2)
📝 packages/core/src/social-providers/dropbox.ts (+2 -2)
📝 packages/core/src/social-providers/facebook.ts (+2 -2)
📝 packages/core/src/social-providers/figma.ts (+2 -2)
📝 packages/core/src/social-providers/github.ts (+2 -2)
📝 packages/core/src/social-providers/gitlab.ts (+2 -2)
📝 packages/core/src/social-providers/google.ts (+2 -2)
📝 packages/core/src/social-providers/huggingface.ts (+2 -2)
📝 packages/core/src/social-providers/kakao.ts (+2 -2)
📝 packages/core/src/social-providers/kick.ts (+2 -2)
📝 packages/core/src/social-providers/line.ts (+2 -2)
📝 packages/core/src/social-providers/linear.ts (+2 -2)
📝 packages/core/src/social-providers/linkedin.ts (+2 -2)
📝 packages/core/src/social-providers/microsoft-entra-id.ts (+3 -3)
📝 packages/core/src/social-providers/naver.ts (+2 -2)

...and 12 more files

📄 Description

Summary by cubic

Tightened linting across auth endpoints, Vue store, and social provider modules by replacing short-circuit side effects with explicit conditionals. Improves readability and linter compliance with no behavior changes.

  • Refactors
    • Replace patterns like condition && array.push(...) with if statements.
    • Update hook registration in to-auth-endpoints, scope disposal in Vue store, and scope merging in all OAuth providers (including Microsoft refresh flow).
    • Preserve logic and outputs; this is style-only.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5655 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 10/28/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/10/28/lint-rules` --- ### 📝 Commits (1) - [`7d772ac`](https://github.com/better-auth/better-auth/commit/7d772ac627c07a2b05fc43d314b0dd097664befa) chore: use strict lint rules ### 📊 Changes **32 files changed** (+64 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/to-auth-endpoints.ts` (+2 -2) 📝 `packages/better-auth/src/client/vue/vue-store.ts` (+1 -1) 📝 `packages/core/src/social-providers/apple.ts` (+2 -2) 📝 `packages/core/src/social-providers/atlassian.ts` (+2 -2) 📝 `packages/core/src/social-providers/cognito.ts` (+2 -2) 📝 `packages/core/src/social-providers/discord.ts` (+2 -2) 📝 `packages/core/src/social-providers/dropbox.ts` (+2 -2) 📝 `packages/core/src/social-providers/facebook.ts` (+2 -2) 📝 `packages/core/src/social-providers/figma.ts` (+2 -2) 📝 `packages/core/src/social-providers/github.ts` (+2 -2) 📝 `packages/core/src/social-providers/gitlab.ts` (+2 -2) 📝 `packages/core/src/social-providers/google.ts` (+2 -2) 📝 `packages/core/src/social-providers/huggingface.ts` (+2 -2) 📝 `packages/core/src/social-providers/kakao.ts` (+2 -2) 📝 `packages/core/src/social-providers/kick.ts` (+2 -2) 📝 `packages/core/src/social-providers/line.ts` (+2 -2) 📝 `packages/core/src/social-providers/linear.ts` (+2 -2) 📝 `packages/core/src/social-providers/linkedin.ts` (+2 -2) 📝 `packages/core/src/social-providers/microsoft-entra-id.ts` (+3 -3) 📝 `packages/core/src/social-providers/naver.ts` (+2 -2) _...and 12 more files_ </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Tightened linting across auth endpoints, Vue store, and social provider modules by replacing short-circuit side effects with explicit conditionals. Improves readability and linter compliance with no behavior changes. - **Refactors** - Replace patterns like condition && array.push(...) with if statements. - Update hook registration in to-auth-endpoints, scope disposal in Vue store, and scope merging in all OAuth providers (including Microsoft refresh flow). - Preserve logic and outputs; this is style-only. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:26:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#23045
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?