github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5286] [MERGED] e2e: add coverage for additional fields #22804

New Issue
Closed
opened 2026-04-15 21:17:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:17:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5286
Author: @himself65
Created: 10/13/2025
Status: ✅ Merged
Merged: 10/13/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/10/13/e2e

📝 Commits (1)

  • 05f9d31 e2e: add coverage for additional fields

📊 Changes

1 file changed (+28 additions, -0 deletions)

View changed files

➕ e2e/smoke/test/fixtures/tsconfig-exact-optional-property-types/src/user-additional-fields.ts (+28 -0)

📄 Description

Related: https://github.com/better-auth/better-auth/issues/5270

Summary by cubic

Added an e2e fixture to verify user.additionalFields with TypeScript exactOptionalPropertyTypes, ensuring signUpEmail accepts the timeZone field without errors. Connects to better-auth issue #5270 by covering additional field handling in sign-up.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5286 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/13/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/10/13/e2e` --- ### 📝 Commits (1) - [`05f9d31`](https://github.com/better-auth/better-auth/commit/05f9d31c983cc7eb044835e2cc5a6d61e3459084) e2e: add coverage for additional fields ### 📊 Changes **1 file changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `e2e/smoke/test/fixtures/tsconfig-exact-optional-property-types/src/user-additional-fields.ts` (+28 -0) </details> ### 📄 Description Related: https://github.com/better-auth/better-auth/issues/5270 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Added an e2e fixture to verify user.additionalFields with TypeScript exactOptionalPropertyTypes, ensuring signUpEmail accepts the timeZone field without errors. Connects to better-auth issue #5270 by covering additional field handling in sign-up. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:17:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#22804
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?