github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5124] [MERGED] v1.3.27 #22693

New Issue
Closed
opened 2026-04-15 21:13:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:13:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5124
Author: @himself65
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/7/2025
Merged by: @himself65

Base: main ← Head: v1.3.27

📝 Commits (10+)

  • 01d44fe fix(sso): OIDC scopes should fallback to provider scopes (#5071)
  • a3e57cb fix(telemetry): avoid async import if telemetry disabled, fix for esbuild (#5086)
  • f7b1639 refactor: move user schema to core
  • 7c58737 refactor: move account schema to core
  • cd599ec refactor: move session schema to core
  • f460bad refactor: move verification schema to core
  • d32d51f fix: session update database hook should expect partial session type (#5056)
  • 4e057dc fix: deprecate options.advanced.generateId type
  • 7e86f3c refactor: move BetterAuthAdvancedOptions to core
  • 29d7218 fix: api keys should properly check if a request is from client or server

📊 Changes

62 files changed (+604 additions, -985 deletions)

View changed files

➖ .github/workflows/branch-rules.yml (+0 -36)
➖ .github/workflows/main-protect.yml (+0 -18)
➖ demo/nextjs/components/ui/canvas-reveal-effect.tsx (+0 -308)
📝 demo/nextjs/package.json (+0 -3)
📝 docs/app/api/ai-chat/route.ts (+1 -0)
📝 docs/components/floating-ai-search.tsx (+3 -0)
📝 docs/components/generate-apple-jwt.tsx (+5 -0)
📝 docs/content/docs/authentication/apple.mdx (+2 -0)
📝 docs/content/docs/integrations/convex.mdx (+2 -2)
📝 e2e/smoke/test/vite.spec.ts (+10 -0)
📝 package.json (+1 -1)
📝 packages/better-auth/src/adapters/adapter-factory/types.ts (+2 -26)
📝 packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts (+2 -2)
📝 packages/better-auth/src/adapters/index.ts (+2 -2)
📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+2 -2)
📝 packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts (+3 -6)
📝 packages/better-auth/src/adapters/mongodb-adapter/mongodb-adapter.ts (+2 -2)
📝 packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts (+2 -2)
📝 packages/better-auth/src/db/schema.ts (+2 -55)
📝 packages/better-auth/src/init.test.ts (+26 -0)

...and 42 more files

📄 Description

Summary by cubic

Centralizes DB schemas and advanced option types in @better-auth/core and unifies adapter debug log types. Also fixes URL path normalization, SSO scopes, and username transform, removes unused demo 3D code, and updates docs and tests.

  • Bug Fixes

    • Normalize baseURL path: handle empty or "/" basePath and avoid double slashes.
    • OIDC scopes now fall back to provider-defined scopes.
    • Username transform guards non-string inputs.
    • Telemetry exported directly (no lazy import) to avoid bundling issues.
    • Client build checks: ensure no async_hooks/AsyncLocalStorage in bundles.
    • Docs: add Apple client secret JWT 6‑month expiry note; fix Convex import path.

  • Migration

    • Import BetterAuthPluginDBSchema and model schema types (User, Account, Session, Verification) from @better-auth/core/db.
    • Use DBAdapterDebugLogOption for adapter debugLogs from @better-auth/core/db/adapter.
    • Move generateId to options.advanced.database.generateId; options.advanced.generateId is deprecated.
    • If using @better-auth/stripe, add @better-auth/core as a peer dependency.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5124 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/7/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `main` ← **Head:** `v1.3.27` --- ### 📝 Commits (10+) - [`01d44fe`](https://github.com/better-auth/better-auth/commit/01d44fe633a5e30ec8c1dfe44a6a9c3ac02644de) fix(sso): OIDC scopes should fallback to provider scopes (#5071) - [`a3e57cb`](https://github.com/better-auth/better-auth/commit/a3e57cbf5710c98f5124642b2c0221513ebf9471) fix(telemetry): avoid async import if telemetry disabled, fix for esbuild (#5086) - [`f7b1639`](https://github.com/better-auth/better-auth/commit/f7b163968e3b38b61bae30d73426035955a7686c) refactor: move user schema to core - [`7c58737`](https://github.com/better-auth/better-auth/commit/7c587377d22e0598aa5beeb94c8af8a3c00a04d4) refactor: move account schema to core - [`cd599ec`](https://github.com/better-auth/better-auth/commit/cd599ec9067ba68bd5e6ae6deab168cf04dd5211) refactor: move session schema to core - [`f460bad`](https://github.com/better-auth/better-auth/commit/f460badc5e17aca4eac2d8a258da5822ba3db47e) refactor: move verification schema to core - [`d32d51f`](https://github.com/better-auth/better-auth/commit/d32d51f837bb644b15778dba563d336c8f99908b) fix: session update database hook should expect partial session type (#5056) - [`4e057dc`](https://github.com/better-auth/better-auth/commit/4e057dc0c4b22dc00c7c8216d540d829641d9abf) fix: deprecate `options.advanced.generateId` type - [`7e86f3c`](https://github.com/better-auth/better-auth/commit/7e86f3c05310294a2c603e0327bab8f0a7b71330) refactor: move `BetterAuthAdvancedOptions` to core - [`29d7218`](https://github.com/better-auth/better-auth/commit/29d72182cdcbfc7b2f71b5f0e73cbe4d31f059fc) fix: api keys should properly check if a request is from client or server ### 📊 Changes **62 files changed** (+604 additions, -985 deletions) <details> <summary>View changed files</summary> ➖ `.github/workflows/branch-rules.yml` (+0 -36) ➖ `.github/workflows/main-protect.yml` (+0 -18) ➖ `demo/nextjs/components/ui/canvas-reveal-effect.tsx` (+0 -308) 📝 `demo/nextjs/package.json` (+0 -3) 📝 `docs/app/api/ai-chat/route.ts` (+1 -0) 📝 `docs/components/floating-ai-search.tsx` (+3 -0) 📝 `docs/components/generate-apple-jwt.tsx` (+5 -0) 📝 `docs/content/docs/authentication/apple.mdx` (+2 -0) 📝 `docs/content/docs/integrations/convex.mdx` (+2 -2) 📝 `e2e/smoke/test/vite.spec.ts` (+10 -0) 📝 `package.json` (+1 -1) 📝 `packages/better-auth/src/adapters/adapter-factory/types.ts` (+2 -26) 📝 `packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/index.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts` (+3 -6) 📝 `packages/better-auth/src/adapters/mongodb-adapter/mongodb-adapter.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts` (+2 -2) 📝 `packages/better-auth/src/db/schema.ts` (+2 -55) 📝 `packages/better-auth/src/init.test.ts` (+26 -0) _...and 42 more files_ </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Centralizes DB schemas and advanced option types in @better-auth/core and unifies adapter debug log types. Also fixes URL path normalization, SSO scopes, and username transform, removes unused demo 3D code, and updates docs and tests. - **Bug Fixes** - Normalize baseURL path: handle empty or "/" basePath and avoid double slashes. - OIDC scopes now fall back to provider-defined scopes. - Username transform guards non-string inputs. - Telemetry exported directly (no lazy import) to avoid bundling issues. - Client build checks: ensure no async_hooks/AsyncLocalStorage in bundles. - Docs: add Apple client secret JWT 6‑month expiry note; fix Convex import path. - **Migration** - Import BetterAuthPluginDBSchema and model schema types (User, Account, Session, Verification) from @better-auth/core/db. - Use DBAdapterDebugLogOption for adapter debugLogs from @better-auth/core/db/adapter. - Move generateId to options.advanced.database.generateId; options.advanced.generateId is deprecated. - If using @better-auth/stripe, add @better-auth/core as a peer dependency. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:13:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#22693
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?