github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4867] [MERGED] e2e: add postgres-js migration test #22529

New Issue
Closed
opened 2026-04-15 21:06:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:06:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4867
Author: @himself65
Created: 9/24/2025
Status: ✅ Merged
Merged: 9/24/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/23/migration

📝 Commits (4)

  • 006c764 e2e: add postgres-js migration test
  • 1b4b2ba test: update database connection string in migration test
  • 50c15da Merge branch 'canary' into himself65/2025/09/23/migration
  • 99057fc chore: lint fix

📊 Changes

4 files changed (+124 additions, -43 deletions)

View changed files

➕ e2e/integration/vanilla-node/e2e/postgres-js.spec.ts (+41 -0)
📝 e2e/integration/vanilla-node/package.json (+4 -1)
📝 e2e/integration/vanilla-node/tsconfig.json (+2 -1)
📝 pnpm-lock.yaml (+77 -41)

📄 Description

Summary by cubic

Add an e2e test that runs better-auth migrations on Postgres using postgres-js + Kysely, and verifies the required tables are created. This ensures our Postgres migration path works end-to-end.

  • New Features

    • Playwright test executes runMigrations with PostgresJSDialect (kysely-postgres-js) and asserts tables: user, session, account, verification. Uses DATABASE_URL or defaults to postgres://postgres:postgres@localhost:5432/postgres.

  • Dependencies

    • Added kysely, kysely-postgres-js, and postgres to e2e/integration/vanilla-node.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4867 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/24/2025 **Status:** ✅ Merged **Merged:** 9/24/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/23/migration` --- ### 📝 Commits (4) - [`006c764`](https://github.com/better-auth/better-auth/commit/006c7640bd5aaf21fc7fac488d77152c7a3ad0f4) e2e: add postgres-js migration test - [`1b4b2ba`](https://github.com/better-auth/better-auth/commit/1b4b2ba08ae71deac0ca810ef416c05b61b5eff1) test: update database connection string in migration test - [`50c15da`](https://github.com/better-auth/better-auth/commit/50c15dacc40e3cefde4bb3f81a4b887a5b8c6d1b) Merge branch 'canary' into himself65/2025/09/23/migration - [`99057fc`](https://github.com/better-auth/better-auth/commit/99057fc938291a21561b4ab2b16a1fd66662c15e) chore: lint fix ### 📊 Changes **4 files changed** (+124 additions, -43 deletions) <details> <summary>View changed files</summary> ➕ `e2e/integration/vanilla-node/e2e/postgres-js.spec.ts` (+41 -0) 📝 `e2e/integration/vanilla-node/package.json` (+4 -1) 📝 `e2e/integration/vanilla-node/tsconfig.json` (+2 -1) 📝 `pnpm-lock.yaml` (+77 -41) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Add an e2e test that runs better-auth migrations on Postgres using postgres-js + Kysely, and verifies the required tables are created. This ensures our Postgres migration path works end-to-end. - **New Features** - Playwright test executes runMigrations with PostgresJSDialect (kysely-postgres-js) and asserts tables: user, session, account, verification. Uses DATABASE_URL or defaults to postgres://postgres:postgres@localhost:5432/postgres. - **Dependencies** - Added kysely, kysely-postgres-js, and postgres to e2e/integration/vanilla-node. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:06:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#22529
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?