github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4753] [MERGED] test: skip if adapter doesn't support transaction #22463

New Issue
Closed
opened 2026-04-15 21:04:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:04:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4753
Author: @himself65
Created: 9/18/2025
Status: ✅ Merged
Merged: 9/18/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/18/skip-test

📝 Commits (5)

  • 028faef test: skip if adapter doesn't support transaction
  • ed0c30d test: skip if adapter doesn't support transaction
  • 233be48 fix: skip if
  • 9e94aac test: snapshot
  • d533be1 test: fix

📊 Changes

4 files changed (+43 additions, -5 deletions)

View changed files

📝 packages/better-auth/src/__snapshots__/init.test.ts.snap (+1 -1)
📝 packages/better-auth/src/adapters/test.ts (+29 -2)
📝 packages/better-auth/src/api/routes/sign-up.test.ts (+4 -1)
📝 packages/better-auth/src/plugins/organization/organization-hook.test.ts (+9 -1)

📄 Description

Summary by cubic

Skips transaction tests when an adapter doesn’t support transactions, preventing false failures and stabilizing CI across adapters.

  • Bug Fixes
    • Added capability checks (adapter.options.adapterConfig.transaction or internal config) and skip logic for transaction-related tests.
    • Applied to SHOULD_ROLLBACK_FAILING_TRANSACTION and the general transaction test.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4753 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/18/2025 **Status:** ✅ Merged **Merged:** 9/18/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/18/skip-test` --- ### 📝 Commits (5) - [`028faef`](https://github.com/better-auth/better-auth/commit/028faef626760f614a2325fd8a936d029fcd3ba0) test: skip if adapter doesn't support transaction - [`ed0c30d`](https://github.com/better-auth/better-auth/commit/ed0c30d84929c0c4a41d504a2a419c62869e3707) test: skip if adapter doesn't support transaction - [`233be48`](https://github.com/better-auth/better-auth/commit/233be48a2068c068af34a098207cc71150b9a7f5) fix: skip if - [`9e94aac`](https://github.com/better-auth/better-auth/commit/9e94aac933fff070da7c37f565977ced530ac7c0) test: snapshot - [`d533be1`](https://github.com/better-auth/better-auth/commit/d533be1429a7916306fbed89aa5edb2d800fb3fa) test: fix ### 📊 Changes **4 files changed** (+43 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/__snapshots__/init.test.ts.snap` (+1 -1) 📝 `packages/better-auth/src/adapters/test.ts` (+29 -2) 📝 `packages/better-auth/src/api/routes/sign-up.test.ts` (+4 -1) 📝 `packages/better-auth/src/plugins/organization/organization-hook.test.ts` (+9 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Skips transaction tests when an adapter doesn’t support transactions, preventing false failures and stabilizing CI across adapters. - **Bug Fixes** - Added capability checks (adapter.options.adapterConfig.transaction or internal config) and skip logic for transaction-related tests. - Applied to SHOULD_ROLLBACK_FAILING_TRANSACTION and the general transaction test. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:04:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#22463
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?