github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4727] [CLOSED] Fix generic OAuth discovery when providers skip JSON headers #22452

New Issue
Closed
opened 2026-04-15 21:03:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 21:03:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4727
Author: @Karavil
Created: 9/17/2025
Status: ❌ Closed

Base: canary ← Head: fix/generic-oauth-discovery-fallback

📝 Commits (1)

  • 380340b fix: tolerate non-json oauth discovery

📊 Changes

2 files changed (+192 additions, -48 deletions)

View changed files

📝 packages/better-auth/src/plugins/generic-oauth/generic-oauth.test.ts (+82 -1)
📝 packages/better-auth/src/plugins/generic-oauth/index.ts (+110 -47)

📄 Description

Fixes generic OAuth discovery to handle non-compliant providers like Clever that return 200 status with incorrect Content-Type headers.

Problem: Clever's discovery endpoint returns application/x-www-form-urlencoded instead of application/json, causing betterFetch to return a Blob and breaking the plugin with INVALID_OAUTH_CONFIGURATION.

Solution: Replace betterFetch with a robust fetchDiscoveryDocument helper that:

  • Uses bare fetch to avoid content-type assumptions
  • Validates responses with Zod schema
  • Logs RFC 8414 §3.1 warnings but continues with best-effort parsing
  • Maintains the same { data, error } API shape for backward compatibility

Testing: Added test coverage for both compliant providers and Clever's non-compliant response format using a lightweight discovery server helper.

Compliant providers work exactly as before, while non-compliant ones now succeed without requiring hardcoded endpoints in downstream apps.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4727 **Author:** [@Karavil](https://github.com/Karavil) **Created:** 9/17/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/generic-oauth-discovery-fallback` --- ### 📝 Commits (1) - [`380340b`](https://github.com/better-auth/better-auth/commit/380340b4f63b0f6d63790ac949d298de2ea7c0e1) fix: tolerate non-json oauth discovery ### 📊 Changes **2 files changed** (+192 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/generic-oauth/generic-oauth.test.ts` (+82 -1) 📝 `packages/better-auth/src/plugins/generic-oauth/index.ts` (+110 -47) </details> ### 📄 Description Fixes generic OAuth discovery to handle non-compliant providers like Clever that return 200 status with incorrect Content-Type headers. **Problem**: Clever's discovery endpoint returns `application/x-www-form-urlencoded` instead of `application/json`, causing betterFetch to return a Blob and breaking the plugin with INVALID_OAUTH_CONFIGURATION. **Solution**: Replace betterFetch with a robust fetchDiscoveryDocument helper that: - Uses bare fetch to avoid content-type assumptions - Validates responses with Zod schema - Logs RFC 8414 §3.1 warnings but continues with best-effort parsing - Maintains the same `{ data, error }` API shape for backward compatibility **Testing**: Added test coverage for both compliant providers and Clever's non-compliant response format using a lightweight discovery server helper. Compliant providers work exactly as before, while non-compliant ones now succeed without requiring hardcoded endpoints in downstream apps. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 21:03:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#22452
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?