github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4579] [MERGED] fix(one-time-token): typo and clean #22360

New Issue
Closed
opened 2026-04-15 20:59:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 20:59:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4579
Author: @gabrielmar
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @himself65

Base: canary ← Head: fix/ott-clean

📝 Commits (2)

  • 526aa04 fix: options typo, remove duplicate function call
  • 6e58fbe revert: zod import

📊 Changes

1 file changed (+6 additions, -9 deletions)

View changed files

📝 packages/better-auth/src/plugins/one-time-token/index.ts (+6 -9)

📄 Description

Summary by cubic

Fixes the one-time-token plugin by correcting the options type name and removing a duplicate token deletion call to avoid redundant DB writes. Also switches to the standard zod import.

  • Bug Fixes

    • Delete verification value once (immediately after lookup) instead of twice.

  • Refactors

    • Rename OneTimeTokenopts to OneTimeTokenOptions.
    • Import z from "zod" instead of "zod/v4".

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4579 **Author:** [@gabrielmar](https://github.com/gabrielmar) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/ott-clean` --- ### 📝 Commits (2) - [`526aa04`](https://github.com/better-auth/better-auth/commit/526aa0480235f7a214a2f4ed785b4a2e8e914c2f) fix: options typo, remove duplicate function call - [`6e58fbe`](https://github.com/better-auth/better-auth/commit/6e58fbe38497318f36869d13c1da118b3d6a5e9f) revert: zod import ### 📊 Changes **1 file changed** (+6 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/one-time-token/index.ts` (+6 -9) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fixes the one-time-token plugin by correcting the options type name and removing a duplicate token deletion call to avoid redundant DB writes. Also switches to the standard zod import. - **Bug Fixes** - Delete verification value once (immediately after lookup) instead of twice. - **Refactors** - Rename OneTimeTokenopts to OneTimeTokenOptions. - Import z from "zod" instead of "zod/v4". <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 20:59:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#22360
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?