github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4325] [MERGED] test: add cookie domain test #22214

New Issue
Closed
opened 2026-04-15 20:53:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 20:53:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4325
Author: @himself65
Created: 8/31/2025
Status: ✅ Merged
Merged: 8/31/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/08/30/domain

📝 Commits (2)

📊 Changes

8 files changed (+162 additions, -95 deletions)

View changed files

📝 biome.json (+2 -1)
➕ e2e/integration/vanilla-node/e2e/domain.spec.ts (+38 -0)
📝 e2e/integration/vanilla-node/e2e/test.spec.ts (+10 -86)
➕ e2e/integration/vanilla-node/e2e/utils.ts (+99 -0)
📝 e2e/integration/vanilla-node/src/main.ts (+5 -5)
📝 e2e/integration/vanilla-node/src/server.ts (+1 -1)
➕ e2e/integration/vanilla-node/vite.config.ts (+7 -0)
📝 pnpm-lock.yaml (+0 -2)

📄 Description

Summary by cubic

Added a cross-domain E2E test to verify session cookie domain behavior. The test runs under test.com and confirms no session cookie is set without a proper cookie domain.

  • Refactors

    • Extracted e2e utilities (start/clean, runClient) and updated existing tests to use them.
    • CORS now echoes the request Origin; Vite allows test.com; Biome ignores playwright-report.

  • Dependencies

    • Added hostparty for local domain testing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4325 **Author:** [@himself65](https://github.com/himself65) **Created:** 8/31/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/08/30/domain` --- ### 📝 Commits (2) - [`9978677`](https://github.com/better-auth/better-auth/commit/9978677c87bb52ddeec0c3b0439344803542820c) test: add cookie domain test - [`b92818a`](https://github.com/better-auth/better-auth/commit/b92818a9f7c93692f4496abc33c65eb0b7ed4db2) fix: lock ### 📊 Changes **8 files changed** (+162 additions, -95 deletions) <details> <summary>View changed files</summary> 📝 `biome.json` (+2 -1) ➕ `e2e/integration/vanilla-node/e2e/domain.spec.ts` (+38 -0) 📝 `e2e/integration/vanilla-node/e2e/test.spec.ts` (+10 -86) ➕ `e2e/integration/vanilla-node/e2e/utils.ts` (+99 -0) 📝 `e2e/integration/vanilla-node/src/main.ts` (+5 -5) 📝 `e2e/integration/vanilla-node/src/server.ts` (+1 -1) ➕ `e2e/integration/vanilla-node/vite.config.ts` (+7 -0) 📝 `pnpm-lock.yaml` (+0 -2) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Added a cross-domain E2E test to verify session cookie domain behavior. The test runs under test.com and confirms no session cookie is set without a proper cookie domain. - **Refactors** - Extracted e2e utilities (start/clean, runClient) and updated existing tests to use them. - CORS now echoes the request Origin; Vite allows test.com; Biome ignores playwright-report. - **Dependencies** - Added hostparty for local domain testing. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 20:53:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#22214
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?