github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3704] [MERGED] fix: cast dates from session to Date when using date methods #21863

New Issue
Closed
opened 2026-04-15 20:39:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 20:39:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3704
Author: @erquhart
Created: 7/30/2025
Status: ✅ Merged
Merged: 8/1/2025
Merged by: @Bekacru

Base: main ← Head: cast-session-dates

📝 Commits (2)

  • 311ed5c fix: cast dates from session to Date when using date methods
  • 2b6bd64 add changeset

📊 Changes

6 files changed (+14 additions, -5 deletions)

View changed files

➕ .changeset/breezy-rice-grin.md (+5 -0)
📝 packages/better-auth/src/api/routes/update-user.ts (+1 -1)
📝 packages/better-auth/src/plugins/mcp/authorize.ts (+1 -1)
📝 packages/better-auth/src/plugins/mcp/index.ts (+3 -1)
📝 packages/better-auth/src/plugins/oidc-provider/authorize.ts (+1 -1)
📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+3 -1)

📄 Description

Follow up from https://github.com/better-auth/better-auth/pull/3611, wrongly assumed the context session was exempt from this issue.

Summary by cubic

Fixed date handling in session objects by casting session.createdAt to a Date before using date methods. This prevents errors when session.createdAt is not already a Date instance.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3704 **Author:** [@erquhart](https://github.com/erquhart) **Created:** 7/30/2025 **Status:** ✅ Merged **Merged:** 8/1/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `cast-session-dates` --- ### 📝 Commits (2) - [`311ed5c`](https://github.com/better-auth/better-auth/commit/311ed5caa4be85406915813e59cde7a60ee1a15f) fix: cast dates from session to Date when using date methods - [`2b6bd64`](https://github.com/better-auth/better-auth/commit/2b6bd6418349ad5ab38c8277bfe5ecbd24dc83d9) add changeset ### 📊 Changes **6 files changed** (+14 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/breezy-rice-grin.md` (+5 -0) 📝 `packages/better-auth/src/api/routes/update-user.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/mcp/authorize.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/mcp/index.ts` (+3 -1) 📝 `packages/better-auth/src/plugins/oidc-provider/authorize.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+3 -1) </details> ### 📄 Description Follow up from https://github.com/better-auth/better-auth/pull/3611, wrongly assumed the context session was exempt from this issue. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed date handling in session objects by casting session.createdAt to a Date before using date methods. This prevents errors when session.createdAt is not already a Date instance. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 20:39:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#21863
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?