github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3155] [MERGED] fix: protocol-specific wildcard trusted origins does not work #21576

New Issue
Closed
opened 2026-04-15 20:27:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 20:27:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3155
Author: @nascode
Created: 6/24/2025
Status: ✅ Merged
Merged: 7/5/2025
Merged by: @Bekacru

Base: main ← Head: fix/protocol-specific-wildcards

📝 Commits (1)

  • 4d0f01a fix(origin-check): support protocol-specific wildcard trusted origins

📊 Changes

2 files changed (+48 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/api/middlewares/origin-check.test.ts (+38 -0)
📝 packages/better-auth/src/api/middlewares/origin-check.ts (+10 -0)

📄 Description

fix https://github.com/better-auth/better-auth/issues/3154

Summary

The changes fix a bug where protocol-specific wildcard patterns like https://*.example.com do not work. This happen because there is a missing logic, if protocol is defined in wildcard trusted origins, we should consider entire url, not only the host to be matched.

Changes made:

  1. Fixed wildcard matching logic.
  2. Added test coverage - New test case validates both positive and negative scenarios for protocol-specific wildcards.
  3. Applied fix to both middleware functions - Both originCheckMiddleware and originCheck now handle protocol-specific wildcards correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3155 **Author:** [@nascode](https://github.com/nascode) **Created:** 6/24/2025 **Status:** ✅ Merged **Merged:** 7/5/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/protocol-specific-wildcards` --- ### 📝 Commits (1) - [`4d0f01a`](https://github.com/better-auth/better-auth/commit/4d0f01a5d3cacab4af8d0501f0dee61e0d99b267) fix(origin-check): support protocol-specific wildcard trusted origins ### 📊 Changes **2 files changed** (+48 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/middlewares/origin-check.test.ts` (+38 -0) 📝 `packages/better-auth/src/api/middlewares/origin-check.ts` (+10 -0) </details> ### 📄 Description fix https://github.com/better-auth/better-auth/issues/3154 ## Summary The changes fix a bug where protocol-specific wildcard patterns like `https://*.example.com` do not work. This happen because there is a missing logic, if protocol is defined in wildcard trusted origins, we should consider entire url, not only the host to be matched. ## Changes made: 1. Fixed wildcard matching logic. 2. Added test coverage - New test case validates both positive and negative scenarios for protocol-specific wildcards. 3. Applied fix to both middleware functions - Both originCheckMiddleware and originCheck now handle protocol-specific wildcards correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 20:27:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#21576
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?