github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-07-17 08:20:03 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2877] [MERGED] fix: correct way detect facebook limited token jwt #21438

New Issue
Closed
opened 2026-04-15 20:22:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 20:22:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2877
Author: @reslear
Created: 6/2/2025
Status: ✅ Merged
Merged: 7/9/2025
Merged by: @Bekacru

Base: main ← Head: patch-11

📝 Commits (3)

  • 0b32f0b fix: correct way detect facebook limited token jwt
  • 3e134e5 Update facebook.ts
  • c0c1d7c Update facebook.ts

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/social-providers/facebook.ts (+4 -3)

📄 Description

I found an issue with how I was detecting the JWT—it was incorrect. I’ve fixed it now.

Because token.split(".").length returns the total number of parts, but what we actually need is the value length 3 like jwt parts

  • changed jwks url

tested in prod

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2877 **Author:** [@reslear](https://github.com/reslear) **Created:** 6/2/2025 **Status:** ✅ Merged **Merged:** 7/9/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `patch-11` --- ### 📝 Commits (3) - [`0b32f0b`](https://github.com/better-auth/better-auth/commit/0b32f0b36f0d2f37a75931390b9bc98ba179e006) fix: correct way detect facebook limited token jwt - [`3e134e5`](https://github.com/better-auth/better-auth/commit/3e134e5f3b1c640aa8d7eb1ba845e9c0ea3294a5) Update facebook.ts - [`c0c1d7c`](https://github.com/better-auth/better-auth/commit/c0c1d7cd8498ca7fa399c9e842d7eeb2952d64c4) Update facebook.ts ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/social-providers/facebook.ts` (+4 -3) </details> ### 📄 Description I found an issue with how I was detecting the JWT—it was incorrect. I’ve fixed it now. Because `token.split(".").length` returns the total number of parts, but what we actually need is the value length 3 like jwt parts - [x] changed jwks url tested in prod --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 20:22:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#21438
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?