github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2238] [CLOSED] feat: add ability to return missing perms #21122

New Issue
Closed
opened 2026-04-15 20:09:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 20:09:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2238
Author: @rxri
Created: 4/12/2025
Status: ❌ Closed

Base: main ← Head: feat/missingPerms

📝 Commits (10+)

  • dfe6071 feat(admin/organization): add ability to return missing perms
  • 8b22c79 fix: add missing owner type
  • 270d11f fix: allow missingPermissions type to be either object or null
  • 7dc35b8 fix: remove null fallback for missingPermissions
  • db2708a fix: types, typos & add tests
  • b813b4c docs: use // ^?
  • f2c0f38 fix: use PermissionType in generic type in CheckPermissionResult
  • 60ebb63 feat(plugins/api-key): add has-permission route
  • 176043e Merge branch 'main' into feat/missingPerms
  • 470eabf chore: remove unnecessary test

📊 Changes

25 files changed (+644 additions, -113 deletions)

View changed files

📝 docs/content/docs/plugins/admin.mdx (+25 -2)
📝 docs/content/docs/plugins/api-key.mdx (+63 -11)
📝 docs/content/docs/plugins/organization.mdx (+24 -1)
📝 packages/better-auth/src/plugins/access/access.test.ts (+31 -0)
📝 packages/better-auth/src/plugins/access/access.ts (+135 -60)
📝 packages/better-auth/src/plugins/access/types.ts (+13 -2)
📝 packages/better-auth/src/plugins/admin/admin.test.ts (+37 -0)
📝 packages/better-auth/src/plugins/admin/admin.ts (+23 -3)
📝 packages/better-auth/src/plugins/admin/client.ts (+14 -3)
📝 packages/better-auth/src/plugins/admin/has-permission.ts (+16 -6)
📝 packages/better-auth/src/plugins/api-key/api-key.test.ts (+28 -10)
📝 packages/better-auth/src/plugins/api-key/index.ts (+1 -0)
📝 packages/better-auth/src/plugins/api-key/routes/create-api-key.ts (+1 -1)
📝 packages/better-auth/src/plugins/api-key/routes/delete-all-expired-api-keys.ts (+1 -1)
📝 packages/better-auth/src/plugins/api-key/routes/delete-api-key.ts (+1 -1)
📝 packages/better-auth/src/plugins/api-key/routes/get-api-key.ts (+1 -1)
➕ packages/better-auth/src/plugins/api-key/routes/has-permission-api-key.ts (+159 -0)
📝 packages/better-auth/src/plugins/api-key/routes/index.ts (+6 -0)
📝 packages/better-auth/src/plugins/api-key/routes/list-api-keys.ts (+1 -1)
📝 packages/better-auth/src/plugins/api-key/routes/update-api-key.ts (+1 -1)

...and 5 more files

📄 Description

need some opinion about it

that would be a great feature for developers that wanna return the missing permissions or just see in the code themselves

all tests (existing & new ones) pass after modifying authorize fn
functions are backwards compatible (if returnMissingPermissions is false or undefined` they will return boolean)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2238 **Author:** [@rxri](https://github.com/rxri) **Created:** 4/12/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/missingPerms` --- ### 📝 Commits (10+) - [`dfe6071`](https://github.com/better-auth/better-auth/commit/dfe60717ff653d3e85f022f597fe76f6a92f24e3) feat(admin/organization): add ability to return missing perms - [`8b22c79`](https://github.com/better-auth/better-auth/commit/8b22c799a76d860cb23a61eb331729ab27657971) fix: add missing `owner` type - [`270d11f`](https://github.com/better-auth/better-auth/commit/270d11f9a7e4a880b078dbc112f1da3271496469) fix: allow `missingPermissions` type to be either `object` or `null` - [`7dc35b8`](https://github.com/better-auth/better-auth/commit/7dc35b8e745e94dc7131e9a9dec14c608a9d5050) fix: remove null fallback for `missingPermissions` - [`db2708a`](https://github.com/better-auth/better-auth/commit/db2708aa4155ae3ff793cdc02fb72a30f32ade95) fix: types, typos & add tests - [`b813b4c`](https://github.com/better-auth/better-auth/commit/b813b4c4b6f36c87217b740d2bdfe1f9ccc1188a) docs: use `// ^?` - [`f2c0f38`](https://github.com/better-auth/better-auth/commit/f2c0f389f3e94af019bee0a301e0a3fd74906d23) fix: use `PermissionType` in generic type in `CheckPermissionResult` - [`60ebb63`](https://github.com/better-auth/better-auth/commit/60ebb63b868d5babc7b1e41a4b518204e5206058) feat(plugins/api-key): add `has-permission` route - [`176043e`](https://github.com/better-auth/better-auth/commit/176043e9f01d8cda384d2408551ecdd11b2bb477) Merge branch 'main' into feat/missingPerms - [`470eabf`](https://github.com/better-auth/better-auth/commit/470eabf98a74725c77cfcd12f2fd791b30845652) chore: remove unnecessary test ### 📊 Changes **25 files changed** (+644 additions, -113 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/plugins/admin.mdx` (+25 -2) 📝 `docs/content/docs/plugins/api-key.mdx` (+63 -11) 📝 `docs/content/docs/plugins/organization.mdx` (+24 -1) 📝 `packages/better-auth/src/plugins/access/access.test.ts` (+31 -0) 📝 `packages/better-auth/src/plugins/access/access.ts` (+135 -60) 📝 `packages/better-auth/src/plugins/access/types.ts` (+13 -2) 📝 `packages/better-auth/src/plugins/admin/admin.test.ts` (+37 -0) 📝 `packages/better-auth/src/plugins/admin/admin.ts` (+23 -3) 📝 `packages/better-auth/src/plugins/admin/client.ts` (+14 -3) 📝 `packages/better-auth/src/plugins/admin/has-permission.ts` (+16 -6) 📝 `packages/better-auth/src/plugins/api-key/api-key.test.ts` (+28 -10) 📝 `packages/better-auth/src/plugins/api-key/index.ts` (+1 -0) 📝 `packages/better-auth/src/plugins/api-key/routes/create-api-key.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/api-key/routes/delete-all-expired-api-keys.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/api-key/routes/delete-api-key.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/api-key/routes/get-api-key.ts` (+1 -1) ➕ `packages/better-auth/src/plugins/api-key/routes/has-permission-api-key.ts` (+159 -0) 📝 `packages/better-auth/src/plugins/api-key/routes/index.ts` (+6 -0) 📝 `packages/better-auth/src/plugins/api-key/routes/list-api-keys.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/api-key/routes/update-api-key.ts` (+1 -1) _...and 5 more files_ </details> ### 📄 Description need some opinion about it that would be a great feature for developers that wanna return the missing permissions or just see in the code themselves all tests (existing & new ones) **pass** after modifying `authorize` fn functions are backwards compatible (if `returnMissingPermissions` is false or undefined` they will return boolean) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 20:09:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#21122
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?