github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #626] [CLOSED] [expo] make the way cookies are handled more resilent #20303

New Issue
Closed
opened 2026-04-15 19:36:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 19:36:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/626
Author: @AlfayezDev
Created: 11/23/2024
Status: ❌ Closed

Base: main ← Head: respect-id-token-expo

📝 Commits (1)

  • 13e5e2e make the way cookies are handled more resilent

📊 Changes

1 file changed (+24 additions, -14 deletions)

View changed files

📝 packages/expo/src/client.ts (+24 -14)

📄 Description

I had a bug where if i use idToken on expo it either crashes the app altogether or makes the redirection very awkward with the browser behavior, i wanted to disable the redirect flag, but this ends up not storing the cookie, i noticed that when the request is successful, set-cookie header does return in the response, which is the same header returned with the Browser, felt like a good and simple solution to this problem.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/626 **Author:** [@AlfayezDev](https://github.com/AlfayezDev) **Created:** 11/23/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `respect-id-token-expo` --- ### 📝 Commits (1) - [`13e5e2e`](https://github.com/better-auth/better-auth/commit/13e5e2e2e1ccb065696f8c0875ade8b9b466f939) make the way cookies are handled more resilent ### 📊 Changes **1 file changed** (+24 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/expo/src/client.ts` (+24 -14) </details> ### 📄 Description I had a bug where if i use idToken on expo it either crashes the app altogether or makes the redirection very awkward with the browser behavior, i wanted to disable the redirect flag, but this ends up not storing the cookie, i noticed that when the request is successful, `set-cookie` header does return in the response, which is the same header returned with the `Browser`, felt like a good and simple solution to this problem. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 19:36:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#20303
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?