github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #592] [MERGED] fix: two-factor breaking asResponse, renamed OTP APIS and added test #20287

New Issue
Closed
opened 2026-04-15 19:35:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 19:35:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/592
Author: @Bekacru
Created: 11/19/2024
Status: ✅ Merged
Merged: 11/19/2024
Merged by: @Bekacru

Base: main ← Head: fix/two-factor

📝 Commits (1)

  • 8cdd975 fix: two-factor breaking asResponse, renamed otp apis and added test

📊 Changes

7 files changed (+193 additions, -18 deletions)

View changed files

📝 docs/content/docs/plugins/2fa.mdx (+19 -5)
📝 packages/better-auth/src/plugins/two-factor/index.ts (+7 -8)
📝 packages/better-auth/src/plugins/two-factor/otp/index.ts (+2 -2)
📝 packages/better-auth/src/plugins/two-factor/totp/index.ts (+1 -1)
📝 packages/better-auth/src/plugins/two-factor/two-factor.test.ts (+110 -2)
➕ packages/better-auth/src/test-utils/headers.ts (+28 -0)
📝 packages/better-auth/src/utils/plugin-helper.ts (+26 -0)

📄 Description

closes #585

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/592 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/two-factor` --- ### 📝 Commits (1) - [`8cdd975`](https://github.com/better-auth/better-auth/commit/8cdd975ad665c09d1084a2c2b9e8219cbd698180) fix: two-factor breaking asResponse, renamed otp apis and added test ### 📊 Changes **7 files changed** (+193 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/plugins/2fa.mdx` (+19 -5) 📝 `packages/better-auth/src/plugins/two-factor/index.ts` (+7 -8) 📝 `packages/better-auth/src/plugins/two-factor/otp/index.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/two-factor/totp/index.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/two-factor/two-factor.test.ts` (+110 -2) ➕ `packages/better-auth/src/test-utils/headers.ts` (+28 -0) 📝 `packages/better-auth/src/utils/plugin-helper.ts` (+26 -0) </details> ### 📄 Description closes #585 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 19:35:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#20287
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?