github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #535] [CLOSED] feat: enhance custom id generation with type support #20250

New Issue
Closed
opened 2026-04-15 19:34:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 19:34:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/535
Author: @jstri
Created: 11/14/2024
Status: ❌ Closed

Base: main ← Head: improve-generateid

📝 Commits (10+)

  • 8325503 feat: unify id generation and introduce type parameter
  • 18ec740 fix: type
  • 7e1334b fix: docs
  • 6024189 chore: improve test
  • f775e29 fix: use generateId to control automatic database id generation
  • 42ad773 fix: improve naming
  • 5be8020 fix: docs
  • cf7dd70 fix: do not process id twice in transformInput
  • 5993366 Merge branch 'main' into improve-generateid
  • 8afb27b wip

📊 Changes

27 files changed (+231 additions, -191 deletions)

View changed files

📝 docs/content/docs/concepts/database.mdx (+16 -13)
📝 packages/better-auth/src/__snapshots__/init.test.ts.snap (+1 -2)
📝 packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts (+22 -19)
📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+21 -19)
📝 packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts (+20 -8)
📝 packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts (+22 -19)
📝 packages/better-auth/src/adapters/test.ts (+1 -1)
📝 packages/better-auth/src/api/routes/callback.ts (+7 -13)
📝 packages/better-auth/src/api/routes/forget-password.ts (+3 -2)
📝 packages/better-auth/src/db/internal-adapter.test.ts (+8 -3)
📝 packages/better-auth/src/db/internal-adapter.ts (+5 -15)
📝 packages/better-auth/src/db/utils.ts (+0 -5)
📝 packages/better-auth/src/db/with-hooks.ts (+8 -5)
📝 packages/better-auth/src/init.ts (+16 -2)
📝 packages/better-auth/src/oauth2/link-account.ts (+2 -2)
📝 packages/better-auth/src/plugins/anonymous/index.ts (+1 -2)
📝 packages/better-auth/src/plugins/generic-oauth/index.ts (+18 -15)
📝 packages/better-auth/src/plugins/multi-session/multi-session.test.ts (+1 -1)
📝 packages/better-auth/src/plugins/organization/adapter.ts (+17 -10)
📝 packages/better-auth/src/plugins/organization/routes/crud-invites.ts (+0 -2)

...and 7 more files

📄 Description

Adds support for custom Stripe-style IDs in generateId function and moves it to AuthContext.

The function is relocated from adapters to AuthContext to:

  • Provide a single, adapter-agnostic interface that works across all adapters (including memory)
  • Enable the possibility for custom ID generation beyond models (e.g., verification tokens)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/535 **Author:** [@jstri](https://github.com/jstri) **Created:** 11/14/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `improve-generateid` --- ### 📝 Commits (10+) - [`8325503`](https://github.com/better-auth/better-auth/commit/8325503cb96e8f71ecc0d0b2b0895a6d6fce1d47) feat: unify id generation and introduce type parameter - [`18ec740`](https://github.com/better-auth/better-auth/commit/18ec7402f370ff2d59f65c5ce7b1eb97eeecfd6a) fix: type - [`7e1334b`](https://github.com/better-auth/better-auth/commit/7e1334b71d7d0062074c49e02abc1c6e2d090fc3) fix: docs - [`6024189`](https://github.com/better-auth/better-auth/commit/602418957f0507c646e2b32e9b1107d78f125bda) chore: improve test - [`f775e29`](https://github.com/better-auth/better-auth/commit/f775e29e51830f515dc506ddca96cfff72d55bf1) fix: use generateId to control automatic database id generation - [`42ad773`](https://github.com/better-auth/better-auth/commit/42ad773e81c7bc962d6f94e6d5650ca1acec7ebd) fix: improve naming - [`5be8020`](https://github.com/better-auth/better-auth/commit/5be80204c1c03993493951a8318528fae4a9de0e) fix: docs - [`cf7dd70`](https://github.com/better-auth/better-auth/commit/cf7dd703fda4fd828774a9a5a4779e11bd54e7c2) fix: do not process id twice in transformInput - [`5993366`](https://github.com/better-auth/better-auth/commit/599336691908775bdba9691145ee575095a3e6e5) Merge branch 'main' into improve-generateid - [`8afb27b`](https://github.com/better-auth/better-auth/commit/8afb27b4e79fef47042c0ddfa0a2c767af5ed3bf) wip ### 📊 Changes **27 files changed** (+231 additions, -191 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/concepts/database.mdx` (+16 -13) 📝 `packages/better-auth/src/__snapshots__/init.test.ts.snap` (+1 -2) 📝 `packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts` (+22 -19) 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+21 -19) 📝 `packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts` (+20 -8) 📝 `packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts` (+22 -19) 📝 `packages/better-auth/src/adapters/test.ts` (+1 -1) 📝 `packages/better-auth/src/api/routes/callback.ts` (+7 -13) 📝 `packages/better-auth/src/api/routes/forget-password.ts` (+3 -2) 📝 `packages/better-auth/src/db/internal-adapter.test.ts` (+8 -3) 📝 `packages/better-auth/src/db/internal-adapter.ts` (+5 -15) 📝 `packages/better-auth/src/db/utils.ts` (+0 -5) 📝 `packages/better-auth/src/db/with-hooks.ts` (+8 -5) 📝 `packages/better-auth/src/init.ts` (+16 -2) 📝 `packages/better-auth/src/oauth2/link-account.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/anonymous/index.ts` (+1 -2) 📝 `packages/better-auth/src/plugins/generic-oauth/index.ts` (+18 -15) 📝 `packages/better-auth/src/plugins/multi-session/multi-session.test.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/organization/adapter.ts` (+17 -10) 📝 `packages/better-auth/src/plugins/organization/routes/crud-invites.ts` (+0 -2) _...and 7 more files_ </details> ### 📄 Description Adds support for custom Stripe-style IDs in `generateId` function and moves it to `AuthContext`. The function is relocated from adapters to `AuthContext` to: - Provide a single, adapter-agnostic interface that works across all adapters (including memory) - Enable the possibility for custom ID generation beyond models (e.g., verification tokens) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 19:34:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#20250
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?