github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #276] [MERGED] feat: require verification before enabling twofactor #20104

New Issue
Closed
opened 2026-04-15 19:28:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 19:28:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/276
Author: @Bekacru
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @Bekacru

Base: main ← Head: fix/totp

📝 Commits (4)

📊 Changes

12 files changed (+325 additions, -186 deletions)

View changed files

📝 demo/nextjs/app/dashboard/user-card.tsx (+52 -13)
📝 docs/content/docs/plugins/2fa.mdx (+20 -13)
📝 examples/nextjs-example/app/dashboard/user-card.tsx (+52 -13)
📝 packages/better-auth/package.json (+1 -1)
📝 packages/better-auth/src/plugins/two-factor/client.ts (+1 -4)
📝 packages/better-auth/src/plugins/two-factor/index.ts (+26 -3)
📝 packages/better-auth/src/plugins/two-factor/otp/index.ts (+2 -2)
📝 packages/better-auth/src/plugins/two-factor/totp/index.ts (+9 -1)
📝 packages/better-auth/src/plugins/two-factor/two-factor.test.ts (+44 -38)
📝 packages/better-auth/src/plugins/two-factor/types.ts (+5 -0)
📝 packages/better-auth/src/plugins/two-factor/verify-middleware.ts (+108 -90)
📝 pnpm-lock.yaml (+5 -8)

📄 Description

closes #129

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/276 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/totp` --- ### 📝 Commits (4) - [`987a8a9`](https://github.com/better-auth/better-auth/commit/987a8a995937c750405079b85dcffbbedc607bd6) chore: update better-call - [`d820898`](https://github.com/better-auth/better-auth/commit/d820898603907e3536c8380b3097d4d21a3e39aa) feat: require verification before enabling twofactor - [`0ff7e74`](https://github.com/better-auth/better-auth/commit/0ff7e740f9e7b7a8613a52281349373cd10c5f36) update demo - [`aef1e5e`](https://github.com/better-auth/better-auth/commit/aef1e5ec9f6b548491a4105a0fc9d6c0bc00ff0c) fix: type ### 📊 Changes **12 files changed** (+325 additions, -186 deletions) <details> <summary>View changed files</summary> 📝 `demo/nextjs/app/dashboard/user-card.tsx` (+52 -13) 📝 `docs/content/docs/plugins/2fa.mdx` (+20 -13) 📝 `examples/nextjs-example/app/dashboard/user-card.tsx` (+52 -13) 📝 `packages/better-auth/package.json` (+1 -1) 📝 `packages/better-auth/src/plugins/two-factor/client.ts` (+1 -4) 📝 `packages/better-auth/src/plugins/two-factor/index.ts` (+26 -3) 📝 `packages/better-auth/src/plugins/two-factor/otp/index.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/two-factor/totp/index.ts` (+9 -1) 📝 `packages/better-auth/src/plugins/two-factor/two-factor.test.ts` (+44 -38) 📝 `packages/better-auth/src/plugins/two-factor/types.ts` (+5 -0) 📝 `packages/better-auth/src/plugins/two-factor/verify-middleware.ts` (+108 -90) 📝 `pnpm-lock.yaml` (+5 -8) </details> ### 📄 Description closes #129 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 19:28:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#20104
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?