github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #232] [MERGED] fix: baseUrl in vue client #20076

New Issue
Closed
opened 2026-04-15 19:27:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 19:27:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/232
Author: @matserix
Created: 10/18/2024
Status: ✅ Merged
Merged: 10/18/2024
Merged by: @Bekacru

Base: main ← Head: vue-fetch-url

📝 Commits (3)

  • 3e59510 fix: baseUrl in vue client for explicit urls
  • 3acfd1b style: revert formatting of imports
  • fb9a32d style: fix linting error

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 packages/better-auth/src/client/vue.ts (+5 -5)

📄 Description

When an explicit baseUrl is defined in the client like shown in the docs. The website will throw following error since it currently tries to call //session.

Error thrown:
[nuxt] [useFetch] the request URL must not start with "//".

This pr uses the already implemented getBaseURL function which is used in other api calls as well, though it will still fallback to /api/auth in edge cases.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/232 **Author:** [@matserix](https://github.com/matserix) **Created:** 10/18/2024 **Status:** ✅ Merged **Merged:** 10/18/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `vue-fetch-url` --- ### 📝 Commits (3) - [`3e59510`](https://github.com/better-auth/better-auth/commit/3e59510aa98af3a14bcf4b1f6b12f5907aa8e4db) fix: baseUrl in vue client for explicit urls - [`3acfd1b`](https://github.com/better-auth/better-auth/commit/3acfd1b1bd1dc412e9d869e968768e9af4731092) style: revert formatting of imports - [`fb9a32d`](https://github.com/better-auth/better-auth/commit/fb9a32ded022ce7f388f4ef1e749534df13e17b5) style: fix linting error ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/client/vue.ts` (+5 -5) </details> ### 📄 Description When an explicit baseUrl is defined in the client like shown in the docs. The website will throw following error since it currently tries to call //session. Error thrown: `[nuxt] [useFetch] the request URL must not start with "//".` This pr uses the already implemented `getBaseURL` function which is used in other api calls as well, though it will still fallback to /api/auth in edge cases. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 19:27:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#20076
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?