github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #106] [CLOSED] fix: handle unsupported returning in Drizzle MySQL adapter #20005

New Issue
Closed
opened 2026-04-15 19:24:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 19:24:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/106
Author: @inducingchaos
Created: 10/6/2024
Status: ❌ Closed

Base: main ← Head: fix/105-drizzle-mysql-unsupported-returning

📝 Commits (3)

  • 1d1e066 chore: draft
  • 2806a75 fix: proper returning method (not working), increase Node memory
  • 5e97998 fix: used ID from data to select instead of returning

📊 Changes

3 files changed (+16934 additions, -14446 deletions)

View changed files

📝 packages/better-auth/package.json (+1 -1)
📝 packages/better-auth/src/adapters/drizzle-adapter/index.ts (+16 -4)
📝 pnpm-lock.yaml (+16917 -14441)

📄 Description

Related Issue

Closes #105

Changes

  • Updated the DTS dev script memory allocation to avoid overflow issues.
  • Modified the Drizzle adapter to bypass the RETURNING clause for MySQL databases, and instead use the ID from data to fetch the row.

Testing

  • Manually tested on a MySQL instance to ensure correct behaviour for insert queries. Update remains untested.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/106 **Author:** [@inducingchaos](https://github.com/inducingchaos) **Created:** 10/6/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/105-drizzle-mysql-unsupported-returning` --- ### 📝 Commits (3) - [`1d1e066`](https://github.com/better-auth/better-auth/commit/1d1e0663b0621d08ecaf082bffb51255a56f1227) chore: draft - [`2806a75`](https://github.com/better-auth/better-auth/commit/2806a7532df014e2213791316027f0eef7aa0698) fix: proper returning method (not working), increase Node memory - [`5e97998`](https://github.com/better-auth/better-auth/commit/5e97998d688735cde69e70f9d241217da46d9a0f) fix: used ID from `data` to select instead of returning ### 📊 Changes **3 files changed** (+16934 additions, -14446 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/package.json` (+1 -1) 📝 `packages/better-auth/src/adapters/drizzle-adapter/index.ts` (+16 -4) 📝 `pnpm-lock.yaml` (+16917 -14441) </details> ### 📄 Description ### Related Issue Closes #105 ### Changes - Updated the DTS dev script memory allocation to avoid overflow issues. - Modified the Drizzle adapter to bypass the `RETURNING` clause for MySQL databases, and instead use the ID from `data` to fetch the row. ### Testing - Manually tested on a MySQL instance to ensure correct behaviour for insert queries. Update remains untested. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 19:24:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#20005
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?