github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-07-16 23:20:14 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #8111] Model name collision when user.modelName is "account" causes wrong FK targets in generated schema #19628

New Issue
Open
opened 2026-04-15 18:54:21 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-15 18:54:21 -05:00
Owner
Copy Link

Originally created by @dilame on GitHub (Feb 23, 2026).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/8111

Summary

When user.modelName is set to "account" and OAuth table is renamed (for example account.modelName = "identity"), generated schema can resolve references incorrectly due to model-key/modelName collision.

Reproduction

betterAuth({
  user: { modelName: "account" },
  account: { modelName: "identity" },
  session: { fields: { userId: "account_id" } },
})

Run better-auth generate (or migrations path).

Expected

  • session.account_id references account(id) (user table)
  • identity.account_id references account(id) (user table)

Actual

In affected builds, references can resolve to wrong target table because resolver prioritizes schema key over modelName match in collision scenarios.

Related PR

Additional context

This reproduces consistently in a real project with custom snake_case fields and custom model names used to avoid reserved words.

Originally created by @dilame on GitHub (Feb 23, 2026). Original GitHub issue: https://github.com/better-auth/better-auth/issues/8111 ### Summary When `user.modelName` is set to `"account"` and OAuth table is renamed (for example `account.modelName = "identity"`), generated schema can resolve references incorrectly due to model-key/modelName collision. ### Reproduction ```ts betterAuth({ user: { modelName: "account" }, account: { modelName: "identity" }, session: { fields: { userId: "account_id" } }, }) ``` Run `better-auth generate` (or migrations path). ### Expected - `session.account_id` references `account(id)` (user table) - `identity.account_id` references `account(id)` (user table) ### Actual In affected builds, references can resolve to wrong target table because resolver prioritizes schema key over `modelName` match in collision scenarios. ### Related PR - https://github.com/better-auth/better-auth/pull/8110 ### Additional context This reproduces consistently in a real project with custom snake_case fields and custom model names used to avoid reserved words.
GiteaMirror added the databaseneeds: infocorebug labels 2026-04-15 18:54:22 -05:00
GiteaMirror commented 2026-04-15 18:54:23 -05:00
Author
Owner
Copy Link

@ping-maxwell commented on GitHub (Feb 23, 2026):

Hey @dilame does this issue only affect generated schemas? after fixing the schema manually, does Better Auth work fine with your configurations?

<!-- gh-comment-id:3946253128 --> @ping-maxwell commented on GitHub (Feb 23, 2026): Hey @dilame does this issue only affect generated schemas? after fixing the schema manually, does Better Auth work fine with your configurations?
GiteaMirror commented 2026-04-15 18:54:24 -05:00
Author
Owner
Copy Link

@dilame commented on GitHub (Feb 23, 2026):

Hi @ping-maxwell

From our side, this was not only a generated-schema problem.

What we observed:

  1. With the original config (user.modelName = "account" and OAuth account remapped), we hit runtime adapter errors (Field ... not found in model ...) even after schema adjustments.
  2. We patched resolution logic locally and got partial progress (e.g. sign-up/sign-in could work), but then hit join-resolution issues (No foreign key found for model account and base model user) and session retrieval inconsistencies depending on the exact mapping/schema state.
  3. Renaming schema objects manually (e.g. moving toward default user model + identity for OAuth account) improved behavior, but did not invalidate the core finding: model key vs modelName alias collisions in adapter resolution are the root issue.

So in short: generated SQL is part of the pain, but runtime resolution (model/field/join lookup under collisions) is the main issue we were trying to fix.

<!-- gh-comment-id:3946286274 --> @dilame commented on GitHub (Feb 23, 2026): Hi @ping-maxwell From our side, this was not only a generated-schema problem. What we observed: 1) With the original config (`user.modelName = "account"` and OAuth `account` remapped), we hit runtime adapter errors (`Field ... not found in model ...`) even after schema adjustments. 2) We patched resolution logic locally and got partial progress (e.g. sign-up/sign-in could work), but then hit join-resolution issues (`No foreign key found for model account and base model user`) and session retrieval inconsistencies depending on the exact mapping/schema state. 3) Renaming schema objects manually (e.g. moving toward default `user` model + `identity` for OAuth account) improved behavior, but did not invalidate the core finding: model key vs modelName alias collisions in adapter resolution are the root issue. So in short: generated SQL is part of the pain, but runtime resolution (model/field/join lookup under collisions) is the main issue we were trying to fix.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug core database needs: info
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#19628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?