github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #4512] Sensitive auth functions should ignore the cookie cache in session middleware #18596

New Issue
Closed
opened 2026-04-15 17:08:00 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-15 17:08:00 -05:00
Owner
Copy Link

Originally created by @widavies on GitHub (Sep 8, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/4512

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

Auth functions like /change-password should always ignore the session cookie cache. Currently, they use the standard session middleware.

I think this is a security risk. Let's say a user changes their password with revokeOtherSessions: true. This will revoke all sessions on the server, but the cookie caches for all existing sessions will live on for the remainder of the cookie cache TTL.

As /change-password will accept the cookie cache, users can change the password and get their session back.

This probably applies to several other auth functions as well.

Describe alternatives you've considered

.

Additional context

No response

Originally created by @widavies on GitHub (Sep 8, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/4512 ### Is this suited for github? - [x] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. _No response_ ### Describe the solution you'd like Auth functions like `/change-password` should always _ignore_ the session cookie cache. Currently, they use the standard [session middleware](https://github.com/better-auth/better-auth/blob/e15113737a5e7b524c188fe07305fc8f310464ce/packages/better-auth/src/api/routes/update-user.ts#L153). I think this is a security risk. Let's say a user changes their password with `revokeOtherSessions: true`. This will revoke all sessions on the server, but the cookie caches for all existing sessions will live on for the remainder of the cookie cache TTL. As `/change-password` will accept the cookie cache, users can change the password and get their session back. This probably applies to several other auth functions as well. ### Describe alternatives you've considered . ### Additional context _No response_
GiteaMirror added the locked label 2026-04-15 17:08:00 -05:00
GiteaMirror commented 2026-04-15 17:08:01 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Sep 9, 2025):

ref #4530

<!-- gh-comment-id:3269653147 --> @Kinfe123 commented on GitHub (Sep 9, 2025): ref #4530
GiteaMirror commented 2026-04-15 17:08:02 -05:00
Author
Owner
Copy Link

@widavies commented on GitHub (Sep 15, 2025):

@Kinfe123 Thanks! You guys are shipping like crazy, appreciate it!

<!-- gh-comment-id:3293866732 --> @widavies commented on GitHub (Sep 15, 2025): @Kinfe123 Thanks! You guys are shipping like crazy, appreciate it!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#18596
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?