github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 06:16:18 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2958] internalAdapter.createSession does not map to options.session.fields #18044

New Issue
Closed
opened 2026-04-15 16:23:46 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-15 16:23:46 -05:00
Owner
Copy Link

Originally created by @gregg-cbs on GitHub (Jun 9, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2958

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  1. Setup better auth with a config that maps session fields to custom field names:
const auth = betterAuth({
  session: {
    fields: {
      userId: "user_id",
      expiresAt: "expires_at",
      ipAddress: "ip_address",
      userAgent: "user_agent",
      createdAt: "date_created",
      updatedAt: "date_updated", 
      guest: "guest",
    }
  }
})
  1. Create a session via the internalAdapter using ctx.context.internalAdapter.createSession()
  2. Note the response is of fields that are better auths naming i.e. "expiresAt" instead of mapped "expires_at" but the session was stored into the database with correct naming "expires_at" instead of "expiresAt".

Current vs. Expected behavior

I expect the response from createSession() to return the mapped fields seeing as it is storing the session into the DB with the mapped field names but instead it is returning non mapped fields.

What version of Better Auth are you using?

1.2.8

Provide environment information

Windows
Nodejs

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
});

Additional context

No response

Originally created by @gregg-cbs on GitHub (Jun 9, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2958 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce 1. Setup better auth with a config that maps session fields to custom field names: ``` const auth = betterAuth({ session: { fields: { userId: "user_id", expiresAt: "expires_at", ipAddress: "ip_address", userAgent: "user_agent", createdAt: "date_created", updatedAt: "date_updated", guest: "guest", } } }) ``` 2. Create a session via the internalAdapter using ctx.context.internalAdapter.createSession() 3. Note the response is of fields that are better auths naming i.e. "expiresAt" instead of mapped "expires_at" but the session was stored into the database with correct naming "expires_at" instead of "expiresAt". ### Current vs. Expected behavior I expect the response from createSession() to return the mapped fields seeing as it is storing the session into the DB with the mapped field names but instead it is returning non mapped fields. ### What version of Better Auth are you using? 1.2.8 ### Provide environment information ```bash Windows Nodejs ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, }); ``` ### Additional context _No response_
GiteaMirror added the locked label 2026-04-15 16:23:46 -05:00
GiteaMirror commented 2026-04-15 16:23:47 -05:00
Author
Owner
Copy Link

@gregg-cbs commented on GitHub (Jun 9, 2025):

Looks like the adapter findOne does not map the fields either... How do we map the fields then?

await ctx.context.adapter.findOne({
  model: "session",
  where: [{field: "token", value: session.token}]
})
<!-- gh-comment-id:2955728373 --> @gregg-cbs commented on GitHub (Jun 9, 2025): Looks like the adapter findOne does not map the fields either... How do we map the fields then? ```ts await ctx.context.adapter.findOne({ model: "session", where: [{field: "token", value: session.token}] }) ```
GiteaMirror commented 2026-04-15 16:23:48 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Jun 9, 2025):

When you use the fields property to map your model fields to custom column names in the database, this only affects the database schem , not the objects returned by the API or used in your app code. but this is something that we will consider as well for future.

<!-- gh-comment-id:2956670570 --> @Kinfe123 commented on GitHub (Jun 9, 2025): When you use the fields property to map your model fields to custom column names in the database, this only affects the database schem , not the objects returned by the API or used in your app code. but this is something that we will consider as well for future.
GiteaMirror commented 2026-04-15 16:23:48 -05:00
Author
Owner
Copy Link

@gregg-cbs commented on GitHub (Jun 10, 2025):

Thats a bit silly because now there is a discrepancy in field names depending on how i get the session.

<!-- gh-comment-id:2958609471 --> @gregg-cbs commented on GitHub (Jun 10, 2025): Thats a bit silly because now there is a discrepancy in field names depending on how i get the session.
GiteaMirror commented 2026-04-15 16:23:48 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Aug 10, 2025):

Duplicate issue. closing now.

<!-- gh-comment-id:3172832458 --> @Kinfe123 commented on GitHub (Aug 10, 2025): Duplicate issue. closing now.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#18044
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?