github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2701] Github auth.api.getAccessToken is broken because Github doesn't supports refresh tokens #17939

New Issue
Closed
opened 2026-04-15 16:18:04 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-15 16:18:04 -05:00
Owner
Copy Link

Originally created by @madarco on GitHub (May 18, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2701

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  • Use the GitHub provider
  • login
  • then try:
await auth.api.getAccessToken({
      headers: await headers(),
      body: {
        providerId: "github",
      },
    });

Also in the Account table the access token expires at and refresh_token are null

Current vs. Expected behavior

A possible fix could be to change the logic in the /get-access-token API to not try to refresh the token if the the refresh_token or accessTokenExpiresAt are null

What version of Better Auth are you using?

1.2.8

Provide environment information

- OS: MacOs
- Node: v22.3.0

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  socialProviders: {
    github: {
      clientId: process.env.GITHUB_CLIENT_ID!,
      clientSecret: process.env.GITHUB_CLIENT_SECRET!,
      scope: ["repo", "read:user", "user:email"],
    }
  }
});

Additional context

No response

Originally created by @madarco on GitHub (May 18, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2701 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce - Use the GitHub provider - login - then try: ``` await auth.api.getAccessToken({ headers: await headers(), body: { providerId: "github", }, }); ``` Also in the Account table the access token expires at and refresh_token are null ### Current vs. Expected behavior A possible fix could be to change the logic in the /get-access-token API to not try to refresh the token if the the refresh_token or accessTokenExpiresAt are null ### What version of Better Auth are you using? 1.2.8 ### Provide environment information ```bash - OS: MacOs - Node: v22.3.0 ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ socialProviders: { github: { clientId: process.env.GITHUB_CLIENT_ID!, clientSecret: process.env.GITHUB_CLIENT_SECRET!, scope: ["repo", "read:user", "user:email"], } } }); ``` ### Additional context _No response_
GiteaMirror added the locked label 2026-04-15 16:18:04 -05:00
GiteaMirror commented 2026-04-15 16:18:07 -05:00
Author
Owner
Copy Link

@alevidals commented on GitHub (May 24, 2025):

I’m not actually sure if the error is caused by what @madarco mentioned, but I’m unable to retrieve the access token using the auth.api.getAccessToken method. For now, I have to get it by accessing the database manually.

<!-- gh-comment-id:2906895173 --> @alevidals commented on GitHub (May 24, 2025): I’m not actually sure if the error is caused by what @madarco mentioned, but I’m unable to retrieve the access token using the auth.api.getAccessToken method. For now, I have to get it by accessing the database manually.
GiteaMirror commented 2026-04-15 16:18:07 -05:00
Author
Owner
Copy Link

@artemoire commented on GitHub (Jun 19, 2025):

From my investigation, a fix should have been released last week in v1.2.9
PR that (hopefully) fixed it: https://github.com/better-auth/better-auth/pull/2764

<!-- gh-comment-id:2989145660 --> @artemoire commented on GitHub (Jun 19, 2025): From my investigation, a fix should have been released last week in `v1.2.9` PR that (hopefully) fixed it: https://github.com/better-auth/better-auth/pull/2764
GiteaMirror commented 2026-04-15 16:18:08 -05:00
Author
Owner
Copy Link

@ping-maxwell commented on GitHub (Jul 8, 2025):

Hey guys, it looks like a fix is merged. I'll close this issue for now. If you guys are still experiencing this issue please do say, I'll re-open this!

<!-- gh-comment-id:3049443116 --> @ping-maxwell commented on GitHub (Jul 8, 2025): Hey guys, it looks like a fix is merged. I'll close this issue for now. If you guys are still experiencing this issue please do say, I'll re-open this!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#17939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?