github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #1958] nullish value on ratelimit key filed #17614

New Issue
Closed
opened 2026-04-15 15:47:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 15:47:50 -05:00
Owner
Copy Link

Originally created by @NimaCodez on GitHub (Mar 23, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/1958

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

Just configure a rate limit on a route (or all routes) and use database as your storage.

Current vs. Expected behavior

What version of Better Auth are you using?

1.2.4

Provide environment information

- OS [Windows 11]
- Browser: [Chrome]
- API Client: [Better Auth's Scala]

Which area(s) are affected? (Select all that apply)

Package

Auth config (if applicable)

import { betterAuth } from "better-auth";
import { Pool } from "pg";
import { openAPI, phoneNumber } from "better-auth/plugins";

export const auth = betterAuth({
  emailAndPassword: {
    enabled: true,
  },
  rateLimit: {
    storage: "database",
    window: parseInt(Bun.env.RATE_LIMIT_TIME_WINDOW ?? "60"),
    max: parseInt(Bun.env.MAX_TRIES ?? "1"),
    enabled: true,
  },
 database: new Pool({
    connectionString: Bun.env.POSTGRES_STRING,
  }),
plugins: [
    openAPI(),
    phoneNumber({
      sendOTP({ phoneNumber, code }, request) {
        console.log(`Sending code: ${code} to phone number: ${phoneNumber}`);
      },

      signUpOnVerification: {
        getTempEmail: (phoneNumber) => {
          return `${phoneNumber}@example.com`;
        },
        //optionally, you can also pass `getTempName` function to generate a temporary name for the user
        getTempName: (phoneNumber) => {
          return phoneNumber; //by default, it will use the phone number as the name
        },
      },
    }),
  ]
)}

Additional context

Hi, I hope you're having some fun time (like us using better-auth)!
I wanted to mention that there's some nullish value on ratelimit key field when the storage is set to database (haven't tested the custom-storage).

here's the photo:

Image

Originally created by @NimaCodez on GitHub (Mar 23, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/1958 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce Just configure a rate limit on a route (or all routes) and use database as your storage. ### Current vs. Expected behavior - ### What version of Better Auth are you using? 1.2.4 ### Provide environment information ```bash - OS [Windows 11] - Browser: [Chrome] - API Client: [Better Auth's Scala] ``` ### Which area(s) are affected? (Select all that apply) Package ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth"; import { Pool } from "pg"; import { openAPI, phoneNumber } from "better-auth/plugins"; export const auth = betterAuth({ emailAndPassword: { enabled: true, }, rateLimit: { storage: "database", window: parseInt(Bun.env.RATE_LIMIT_TIME_WINDOW ?? "60"), max: parseInt(Bun.env.MAX_TRIES ?? "1"), enabled: true, }, database: new Pool({ connectionString: Bun.env.POSTGRES_STRING, }), plugins: [ openAPI(), phoneNumber({ sendOTP({ phoneNumber, code }, request) { console.log(`Sending code: ${code} to phone number: ${phoneNumber}`); }, signUpOnVerification: { getTempEmail: (phoneNumber) => { return `${phoneNumber}@example.com`; }, //optionally, you can also pass `getTempName` function to generate a temporary name for the user getTempName: (phoneNumber) => { return phoneNumber; //by default, it will use the phone number as the name }, }, }), ] )} ``` ### Additional context Hi, I hope you're having some fun time (like us using better-auth)! I wanted to mention that there's some nullish value on ratelimit key field when the storage is set to database (haven't tested the custom-storage). here's the photo: ![Image](https://github.com/user-attachments/assets/e3fa4610-1634-4b6b-9485-aa2a5a7a3150)
GiteaMirror added the lockedbug labels 2026-04-15 15:47:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#17614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?