github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #934] better auth social providers type #17138

New Issue
Closed
opened 2026-04-15 15:06:01 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-15 15:06:01 -05:00
Owner
Copy Link

Originally created by @draylegend on GitHub (Dec 18, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/934

Issue

TS2322: Type string is not assignable to type
'github' | 'apple' | 'discord' | 'facebook' | 'google' | 'microsoft' | 'spotify' | 'twitch' | 'twitter' | 'dropbox' | 'linkedin' | 'gitlab' | 'reddit'

auth-5DAdlxmK.d.ts(8131, 21): The expected type comes from property provider which is declared here on type

Prettify<{ provider: "github" | "apple" | "discord" | "facebook" | "google" | "microsoft" | "spotify" | "twitch" | "twitter" | "dropbox" | "linkedin" | "gitlab" | "reddit"; idToken?: { ...; } | undefined; callbackURL?: string | undefined; newUserCallbackURL?: string | undefined; errorCallbackURL?: string | undefined...

image

Describe the solution you'd like

I need the type BetterAuthSocialProviders or similar to properly annotate arguments/variables

  protected signInWith(provider: BetterAuthSocialProviders) {
    signIn.social({ provider });
  }

export type BetterAuthSocialProviders = 'google' | ...;
Originally created by @draylegend on GitHub (Dec 18, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/934 ### Issue ```ts TS2322: Type string is not assignable to type 'github' | 'apple' | 'discord' | 'facebook' | 'google' | 'microsoft' | 'spotify' | 'twitch' | 'twitter' | 'dropbox' | 'linkedin' | 'gitlab' | 'reddit' auth-5DAdlxmK.d.ts(8131, 21): The expected type comes from property provider which is declared here on type Prettify<{ provider: "github" | "apple" | "discord" | "facebook" | "google" | "microsoft" | "spotify" | "twitch" | "twitter" | "dropbox" | "linkedin" | "gitlab" | "reddit"; idToken?: { ...; } | undefined; callbackURL?: string | undefined; newUserCallbackURL?: string | undefined; errorCallbackURL?: string | undefined... ``` ![image](https://github.com/user-attachments/assets/4ad07892-29ed-4f9d-92ab-0b7dcf8f991b) ### Describe the solution you'd like I need the type `BetterAuthSocialProviders` or similar to properly annotate arguments/variables ```ts protected signInWith(provider: BetterAuthSocialProviders) { signIn.social({ provider }); } ``` ```ts export type BetterAuthSocialProviders = 'google' | ...; ```
GiteaMirror added the locked label 2026-04-15 15:06:01 -05:00
GiteaMirror commented 2026-04-15 15:06:05 -05:00
Author
Owner
Copy Link

@emroot commented on GitHub (Dec 18, 2024):

can you use this instead?
auth being your auth config.

type Providers = keyof typeof auth.options.socialProviders;

This will return only the providers that you are actually using.

<!-- gh-comment-id:2552041675 --> @emroot commented on GitHub (Dec 18, 2024): can you use this instead? auth being your auth config. ``` type Providers = keyof typeof auth.options.socialProviders; ``` This will return only the providers that you are actually using.
GiteaMirror commented 2026-04-15 15:06:07 -05:00
Author
Owner
Copy Link

@daveycodez commented on GitHub (Dec 18, 2024):

That would be doable but it would keep the application's codebase cleaner to have an import type SocialProviders coming out of the lib.

<!-- gh-comment-id:2552093310 --> @daveycodez commented on GitHub (Dec 18, 2024): That would be doable but it would keep the application's codebase cleaner to have an import type SocialProviders coming out of the lib.
GiteaMirror commented 2026-04-15 15:06:08 -05:00
Author
Owner
Copy Link

@emroot commented on GitHub (Dec 18, 2024):

Yeah I think that would be great to have if you need all the providers but this approach will limit to only the providers you are actually using, less error prone for someone to use a provider that is not implemented.

<!-- gh-comment-id:2552170770 --> @emroot commented on GitHub (Dec 18, 2024): Yeah I think that would be great to have if you need all the providers but this approach will limit to only the providers you are actually using, less error prone for someone to use a provider that is not implemented.
GiteaMirror commented 2026-04-15 15:06:09 -05:00
Author
Owner
Copy Link

@draylegend commented on GitHub (Dec 19, 2024):

@emroot thank you! Actually even better than I could imagine! In fact I just need already configured providers reducing the providers' list.

@daveycodez interesting point. The extra line suggested by @emroot doesn't hurt me ^^

<!-- gh-comment-id:2553283935 --> @draylegend commented on GitHub (Dec 19, 2024): @emroot thank you! Actually even better than I could imagine! In fact I just need already configured providers reducing the providers' list. @daveycodez interesting point. The extra line suggested by @emroot doesn't hurt me ^^
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#17138
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?