github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #740] Error Handling in authClient.signIn.email Doesn't Catch All Errors #17035

New Issue
Closed
opened 2026-04-15 14:58:47 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-15 14:58:47 -05:00
Owner
Copy Link

Originally created by @adrian-kong on GitHub (Dec 3, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/740

Describe the bug
The authClient.signIn.email function, as implemented from the docs, fails to catch all errors, such as Cross-Origin Request Blocked errors caused by CORS policy violations. This happens because the current implementation relies solely on the onError callback provided in the options, which does not account for errors thrown at a higher level.

To Reproduce

As example in docs:

      await authClient.signIn.email(
        { email, password },
        {
          onRequest: () => {
          },
          onSuccess: () => {
          },
          onError: (ctx) => {
            console.error(ctx.error.message);
          },
        }
      );

will error in backend

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource

Expected behavior
onError should handle the error or docs to be updated with try catch

Originally created by @adrian-kong on GitHub (Dec 3, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/740 **Describe the bug** The authClient.signIn.email function, as implemented from the docs, fails to catch all errors, such as Cross-Origin Request Blocked errors caused by CORS policy violations. This happens because the current implementation relies solely on the onError callback provided in the options, which does not account for errors thrown at a higher level. **To Reproduce** As example in docs: ```js await authClient.signIn.email( { email, password }, { onRequest: () => { }, onSuccess: () => { }, onError: (ctx) => { console.error(ctx.error.message); }, } ); ``` will error in backend ``` Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource ``` **Expected behavior** onError should handle the error or docs to be updated with try catch
GiteaMirror added the locked label 2026-04-15 14:58:47 -05:00
GiteaMirror commented 2026-04-15 14:58:50 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 3, 2024):

that's is intentional behavior. It only supposed to catch api returned errors.

<!-- gh-comment-id:2514322283 --> @Bekacru commented on GitHub (Dec 3, 2024): that's is intentional behavior. It only supposed to catch api returned errors.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#17035
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?