github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #539] Incorrect Session Expiration Calculation with Secondary Storage #16942

New Issue
Closed
opened 2026-04-15 14:53:50 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-15 14:53:50 -05:00
Owner
Copy Link

Originally created by @wh5938316 on GitHub (Nov 15, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/539

@Bekacru

When enabling secondary storage, the session expiration period is significantly shortened. The root cause lies in the following issue: the code.

The Date.now() function returns the value in milliseconds, while the sessionExpiration variable is in seconds. The code incorrectly adds these two values directly without converting sessionExpiration to milliseconds using getDate(sessionExpiration, "ms"). This results in session expiration being 1/1000th of the intended duration when secondary storage is enabled.

I have submitted a PR #524 to solve this issue. Please merge it at your earliest convenience, as this is a critical bug affecting session validity.

Thank you!

Originally created by @wh5938316 on GitHub (Nov 15, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/539 @Bekacru When enabling secondary storage, the session expiration period is significantly shortened. The root cause lies in the following issue: [the code](https://github.com/better-auth/better-auth/blob/1b6c89e8d3d0c7385dce655b5dd1b43399859858/packages/better-auth/src/db/internal-adapter.ts#L237C51-L237C68). The `Date.now()` function returns the value in milliseconds, while the sessionExpiration variable is in seconds. The code incorrectly adds these two values directly without converting sessionExpiration to milliseconds using `getDate(sessionExpiration, "ms")`. This results in session expiration being 1/1000th of the intended duration when secondary storage is enabled. I have submitted a PR #524 to solve this issue. Please merge it at your earliest convenience, as this is a critical bug affecting session validity. Thank you!
GiteaMirror added the locked label 2026-04-15 14:53:50 -05:00
GiteaMirror commented 2026-04-15 14:53:51 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Nov 15, 2024):

First, the only issue should occur is when trying to list active sessions from secondary storage. Session expiration isn't determined by the value you mentioned, it's determined by the actual expiresAt field stored in the data. The value you highlighted is intended to be used as ttl, which, as mentioned in the docs, is specified in seconds, not ms.
And thank you for the PR, but getDate() returns the current time plus the time range, it doesn't convert it to ms. A patch has already been released in the latest version, so that shouldn't be an issue anymore.

<!-- gh-comment-id:2478330191 --> @Bekacru commented on GitHub (Nov 15, 2024): First, the only issue should occur is when trying to list active sessions from secondary storage. Session expiration isn't determined by the value you mentioned, it's determined by the actual `expiresAt` field stored in the data. The value you highlighted is intended to be used as `ttl`, which, as mentioned in the docs, is specified in seconds, not ms. And thank you for the PR, but `getDate()` returns the current time plus the time range, it doesn't convert it to ms. A patch has already been released in the latest version, so that shouldn't be an issue anymore.
GiteaMirror commented 2026-04-15 14:53:52 -05:00
Author
Owner
Copy Link

@wh5938316 commented on GitHub (Nov 15, 2024):

@Bekacru
Apologies for not thoroughly reviewing the usage of getDate. I’m glad it’s fixed now.

Regarding secondary storage, it does seem to have quite a few issues. Could you take a look at the issue I posted about it #522?

Thanks!

<!-- gh-comment-id:2478589473 --> @wh5938316 commented on GitHub (Nov 15, 2024): @Bekacru Apologies for not thoroughly reviewing the usage of getDate. I’m glad it’s fixed now. Regarding secondary storage, it does seem to have quite a few issues. Could you take a look at the issue I posted about it #522? Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16942
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?