github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #9104] test(prisma-adapter): add coverage for empty where condition #16684

New Issue
Open
opened 2026-04-13 10:38:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:38:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/9104
Author: @MuzzaiyyanHussain
Created: 4/10/2026
Status: 🔄 Open

Base: main ← Head: test/prisma-empty-where

📝 Commits (1)

  • 545bec7 test(prisma-adapter): add coverage for empty where condition

📊 Changes

1 file changed (+19 additions, -0 deletions)

View changed files

📝 packages/prisma-adapter/src/prisma-adapter.test.ts (+19 -0)

📄 Description

Summary

Adds test coverage for edge cases in the Prisma adapter update method.

Changes

  • Added a test to verify behavior when where condition is empty
  • Ensured the adapter returns null instead of throwing an error

Why

The current behavior for an empty where condition was not explicitly tested.
This PR ensures the behavior is documented and prevents accidental regressions in the future.

Notes

  • No changes to existing logic
  • Only test coverage improvements

Summary by cubic

Add a unit test ensuring prisma-adapter’s update returns null when where is empty. Documents expected behavior and guards against regressions.

Written for commit 545bec742f. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/9104 **Author:** [@MuzzaiyyanHussain](https://github.com/MuzzaiyyanHussain) **Created:** 4/10/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `test/prisma-empty-where` --- ### 📝 Commits (1) - [`545bec7`](https://github.com/better-auth/better-auth/commit/545bec742f81343dbf515908abed31eb7db94517) test(prisma-adapter): add coverage for empty where condition ### 📊 Changes **1 file changed** (+19 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/prisma-adapter/src/prisma-adapter.test.ts` (+19 -0) </details> ### 📄 Description ## Summary Adds test coverage for edge cases in the Prisma adapter `update` method. ## Changes - Added a test to verify behavior when `where` condition is empty - Ensured the adapter returns `null` instead of throwing an error ## Why The current behavior for an empty `where` condition was not explicitly tested. This PR ensures the behavior is documented and prevents accidental regressions in the future. ## Notes - No changes to existing logic - Only test coverage improvements <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Add a unit test ensuring `prisma-adapter`’s `update` returns null when `where` is empty. Documents expected behavior and guards against regressions. <sup>Written for commit 545bec742f81343dbf515908abed31eb7db94517. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:38:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16684
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?