github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #9042] [MERGED] fix(ci): make lint:dependencies script cross-platform #16642

New Issue
Closed
opened 2026-04-13 10:37:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:37:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/9042
Author: @gustavovalverde
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/8/2026
Merged by: @gustavovalverde

Base: main ← Head: fix/cross-platform-knip-script

📝 Commits (1)

  • 10bcb3a fix: make lint:dependencies script cross-platform

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 package.json (+1 -1)

📄 Description

Summary

  • Replace POSIX-only shell constructs ($?, [ -eq ], ;) in the lint:dependencies script with && chaining
  • The previous script used bash-specific syntax that breaks on Windows (cmd.exe / PowerShell)
  • && works identically across bash, zsh, cmd.exe, and PowerShell

Summary by cubic

Make the lint:dependencies script cross‑platform by replacing POSIX-only exit-code checks with && chaining. Fixes failures on Windows (cmd/PowerShell) while keeping the same behavior on Unix shells.

Written for commit 10bcb3a8a9. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/9042 **Author:** [@gustavovalverde](https://github.com/gustavovalverde) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/8/2026 **Merged by:** [@gustavovalverde](https://github.com/gustavovalverde) **Base:** `main` ← **Head:** `fix/cross-platform-knip-script` --- ### 📝 Commits (1) - [`10bcb3a`](https://github.com/better-auth/better-auth/commit/10bcb3a8a9b7f096df647988342e6ee5bcc525e0) fix: make lint:dependencies script cross-platform ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -1) </details> ### 📄 Description ## Summary - Replace POSIX-only shell constructs (`$?`, `[ -eq ]`, `;`) in the `lint:dependencies` script with `&&` chaining - The previous script used bash-specific syntax that breaks on Windows (`cmd.exe` / PowerShell) - `&&` works identically across bash, zsh, cmd.exe, and PowerShell <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Make the `lint:dependencies` script cross‑platform by replacing POSIX-only exit-code checks with `&&` chaining. Fixes failures on Windows (cmd/PowerShell) while keeping the same behavior on Unix shells. <sup>Written for commit 10bcb3a8a9b7f096df647988342e6ee5bcc525e0. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:37:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?