github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8992] [MERGED] chore: fix release-blocking Changesets null versions #16601

New Issue
Closed
opened 2026-04-13 10:36:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:36:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8992
Author: @gustavovalverde
Created: 4/6/2026
Status: ✅ Merged
Merged: 4/6/2026
Merged by: @gustavovalverde

Base: next ← Head: codex/fix-next-release-ci

📝 Commits (1)

  • 2541942 fix(release): ignore private test packages on next

📊 Changes

3 files changed (+3 additions, -4 deletions)

View changed files

📝 .changeset/config.json (+1 -0)
📝 e2e/adapter/package.json (+1 -2)
📝 e2e/integration/test-utils/package.json (+1 -2)

📄 Description

Summary

  • stop Changesets from versioning private packages on next
  • remove the invalid "version": null fields written into the two private e2e packages
  • unblock ci and e2e on the release promotion flow

Root Cause

The promote workflow on next exits pre-release mode and versions packages in one pass. Because .changeset/config.json did not set privatePackages, Changesets defaulted to versioning private packages. Two private e2e packages had no original version field, and the pre-exit/version flow wrote "version": null into their package.json files.

Turbo then failed very early while parsing workspace package manifests, so the branch-level ci and e2e checks both failed before real test execution.

Impact

This unblocks the stuck release path by repairing the current next line and preventing the same private-package versioning issue from being reintroduced on future promote runs.

Validation

  • pnpm build
  • confirmed origin/next failures were caused by package_json_parse_error on the two version: null entries

Summary by cubic

Stops versioning of private e2e packages on next and removes invalid version fields. Restores CI and e2e checks in the release promotion flow.

  • Bug Fixes
    • Set "privatePackages": false in .changeset/config.json to ignore private packages during promote.
    • Removed "version": null from e2e/adapter/package.json and e2e/integration/test-utils/package.json to fix workspace manifest parsing and allow CI to run.

Written for commit 25419428c5. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8992 **Author:** [@gustavovalverde](https://github.com/gustavovalverde) **Created:** 4/6/2026 **Status:** ✅ Merged **Merged:** 4/6/2026 **Merged by:** [@gustavovalverde](https://github.com/gustavovalverde) **Base:** `next` ← **Head:** `codex/fix-next-release-ci` --- ### 📝 Commits (1) - [`2541942`](https://github.com/better-auth/better-auth/commit/25419428c5cd3e915f3991a5e54d17950ab7cf98) fix(release): ignore private test packages on next ### 📊 Changes **3 files changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.changeset/config.json` (+1 -0) 📝 `e2e/adapter/package.json` (+1 -2) 📝 `e2e/integration/test-utils/package.json` (+1 -2) </details> ### 📄 Description ## Summary - stop Changesets from versioning private packages on `next` - remove the invalid `"version": null` fields written into the two private e2e packages - unblock `ci` and `e2e` on the release promotion flow ## Root Cause The promote workflow on `next` exits pre-release mode and versions packages in one pass. Because `.changeset/config.json` did not set `privatePackages`, Changesets defaulted to versioning private packages. Two private e2e packages had no original `version` field, and the pre-exit/version flow wrote `"version": null` into their `package.json` files. Turbo then failed very early while parsing workspace package manifests, so the branch-level `ci` and `e2e` checks both failed before real test execution. ## Impact This unblocks the stuck release path by repairing the current `next` line and preventing the same private-package versioning issue from being reintroduced on future promote runs. ## Validation - `pnpm build` - confirmed `origin/next` failures were caused by `package_json_parse_error` on the two `version: null` entries <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Stops versioning of private e2e packages on `next` and removes invalid version fields. Restores CI and e2e checks in the release promotion flow. - **Bug Fixes** - Set `"privatePackages": false` in `.changeset/config.json` to ignore private packages during promote. - Removed `"version": null` from `e2e/adapter/package.json` and `e2e/integration/test-utils/package.json` to fix workspace manifest parsing and allow CI to run. <sup>Written for commit 25419428c5cd3e915f3991a5e54d17950ab7cf98. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:36:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16601
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?