github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8964] [MERGED] fix(ci): run tests in merge queue, add summary gate jobs, cover next branch #16578

New Issue
Closed
opened 2026-04-13 10:35:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:35:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8964
Author: @gustavovalverde
Created: 4/5/2026
Status: ✅ Merged
Merged: 4/5/2026
Merged by: @gustavovalverde

Base: main ← Head: fix/ci-quality-gates

📝 Commits (2)

  • 7df91c6 fix(ci): run tests in merge queue, add summary gate jobs, cover next branch
  • 9975cf3 refactor(ci): use re-actors/alls-green for gate jobs

📊 Changes

4 files changed (+23 additions, -39 deletions)

View changed files

📝 .cspell/tech-terms.txt (+3 -0)
📝 .github/workflows/ci.yml (+9 -12)
📝 .github/workflows/e2e.yml (+10 -26)
📝 .github/workflows/zizmor.yml (+1 -1)

📄 Description

Summary

  • Run tests in merge queue. Removes merge_group skip conditions from test, integration, and adapter-integration jobs. The merge queue was only running lint/typecheck/smoke — defeating its purpose of catching combined-PR breakage.
  • Add summary gate jobs. ci and e2e jobs aggregate all matrix results. Required status checks now reference these stable names instead of individual matrix jobs (test (22.x), @better-auth-test/memory-adapter Integration Test, etc.). Matrix changes (add Node versions, adapters) no longer require ruleset updates.
  • Cover next branch. Adds next to e2e.yml and zizmor.yml push triggers so post-merge validation runs on both branches.

Ruleset changes (applied via API, not in this diff)

Both "Protect main" and "Protect next" rulesets updated:

Change Before After
Required checks lint, test (22.x), Smoke test, memory-adapter Integration Test, typecheck ci, e2e, Validate PR title
check_response_timeout_minutes 60 15
min_entries_to_merge_wait_minutes 5 0

Test plan

  • Open a PR and verify ci and e2e gate jobs appear as required checks
  • Verify Validate PR title blocks non-conventional titles
  • Verify merge queue runs the full test suite (not just lint/typecheck)
  • Push to next and verify e2e and zizmor workflows trigger

Summary by cubic

Run the full test suite in the merge queue and add stable gate jobs (ci, e2e) powered by re-actors/alls-green for consistent required checks. Also run post-merge validation on the next branch.

  • Refactors
    • Removed merge queue skips so test, integration, and adapter-integration run in merge_group.
    • Added ci and e2e summary jobs using re-actors/alls-green; required checks use these stable names, so matrix changes don’t need ruleset updates.
    • Triggered e2e and zizmor on pushes to next as well as main.
    • Added denoland, zizmor, and zizmorcore to .cspell.

Written for commit 9975cf3cc0. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8964 **Author:** [@gustavovalverde](https://github.com/gustavovalverde) **Created:** 4/5/2026 **Status:** ✅ Merged **Merged:** 4/5/2026 **Merged by:** [@gustavovalverde](https://github.com/gustavovalverde) **Base:** `main` ← **Head:** `fix/ci-quality-gates` --- ### 📝 Commits (2) - [`7df91c6`](https://github.com/better-auth/better-auth/commit/7df91c6d78c90e4b3cae66becf5dbca36e32b625) fix(ci): run tests in merge queue, add summary gate jobs, cover next branch - [`9975cf3`](https://github.com/better-auth/better-auth/commit/9975cf3cc0644509750a1c217673f963c83c29a8) refactor(ci): use re-actors/alls-green for gate jobs ### 📊 Changes **4 files changed** (+23 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `.cspell/tech-terms.txt` (+3 -0) 📝 `.github/workflows/ci.yml` (+9 -12) 📝 `.github/workflows/e2e.yml` (+10 -26) 📝 `.github/workflows/zizmor.yml` (+1 -1) </details> ### 📄 Description ## Summary - **Run tests in merge queue.** Removes `merge_group` skip conditions from `test`, `integration`, and `adapter-integration` jobs. The merge queue was only running lint/typecheck/smoke — defeating its purpose of catching combined-PR breakage. - **Add summary gate jobs.** `ci` and `e2e` jobs aggregate all matrix results. Required status checks now reference these stable names instead of individual matrix jobs (`test (22.x)`, `@better-auth-test/memory-adapter Integration Test`, etc.). Matrix changes (add Node versions, adapters) no longer require ruleset updates. - **Cover `next` branch.** Adds `next` to `e2e.yml` and `zizmor.yml` push triggers so post-merge validation runs on both branches. ## Ruleset changes (applied via API, not in this diff) Both "Protect main" and "Protect next" rulesets updated: | Change | Before | After | |--------|--------|-------| | Required checks | `lint`, `test (22.x)`, `Smoke test`, `memory-adapter Integration Test`, `typecheck` | `ci`, `e2e`, `Validate PR title` | | `check_response_timeout_minutes` | 60 | 15 | | `min_entries_to_merge_wait_minutes` | 5 | 0 | ## Test plan - [ ] Open a PR and verify `ci` and `e2e` gate jobs appear as required checks - [ ] Verify `Validate PR title` blocks non-conventional titles - [ ] Verify merge queue runs the full test suite (not just lint/typecheck) - [ ] Push to `next` and verify e2e and zizmor workflows trigger <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Run the full test suite in the merge queue and add stable gate jobs (`ci`, `e2e`) powered by `re-actors/alls-green` for consistent required checks. Also run post-merge validation on the `next` branch. - **Refactors** - Removed merge queue skips so `test`, `integration`, and `adapter-integration` run in `merge_group`. - Added `ci` and `e2e` summary jobs using `re-actors/alls-green`; required checks use these stable names, so matrix changes don’t need ruleset updates. - Triggered `e2e` and `zizmor` on pushes to `next` as well as `main`. - Added `denoland`, `zizmor`, and `zizmorcore` to `.cspell`. <sup>Written for commit 9975cf3cc0644509750a1c217673f963c83c29a8. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:35:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16578
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?