github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Rate limit bugs #165

New Issue
Closed
opened 2026-03-13 07:35:58 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-03-13 07:35:58 -05:00
Owner
Copy Link

Originally created by @Aziz-AXG on GitHub (Nov 2, 2024).

Trying to add rate Limit to the auth and found some bugs

1- trying to add custom Rules to Phone Number plugin and it don't work but the main rate Limit work fine

rateLimit: {
    enabled: true,
    window: 60,
    max: 30,
    customRules: {
      "/phone-number/send-otp": {
        window: 60,
        max: 1,
      },
    },
  },

2- if i add database storage all rate Limit don't work without any error log

  rateLimit: {
    enabled: true,
    storage: "database",
    tableName: "rateLimit",
    window: 60,
    max: 30,
    customRules: {
      "/phone-number/send-otp": {
        window: 60,
        max: 1,
      },
    },
  },

even after make sure the rate Limit schema is linked

database: drizzleAdapter(db, {
    provider: "sqlite",
    schema: {
      ...schema,
      user: schema.User,
      rateLimit: schema.rateLimit,
    },
  }),

and the rateLimit table in db Is empty
Desktop: win 11, mode.js 22.6.0

Originally created by @Aziz-AXG on GitHub (Nov 2, 2024). Trying to add rate Limit to the auth and found some bugs 1- trying to add custom Rules to Phone Number plugin and it don't work but the main rate Limit work fine ``` rateLimit: { enabled: true, window: 60, max: 30, customRules: { "/phone-number/send-otp": { window: 60, max: 1, }, }, }, ``` 2- if i add database storage all rate Limit don't work without any error log ``` rateLimit: { enabled: true, storage: "database", tableName: "rateLimit", window: 60, max: 30, customRules: { "/phone-number/send-otp": { window: 60, max: 1, }, }, }, ``` even after make sure the rate Limit schema is linked ``` database: drizzleAdapter(db, { provider: "sqlite", schema: { ...schema, user: schema.User, rateLimit: schema.rateLimit, }, }), ``` and the rateLimit table in db Is empty Desktop: win 11, mode.js 22.6.0
GiteaMirror commented 2026-03-13 07:35:58 -05:00
Author
Owner
Copy Link

@jstri commented on GitHub (Nov 26, 2024):

Rate limit customStorage configuration is either not implemented (at least I couldn't find it) or not being respected.

@jstri commented on GitHub (Nov 26, 2024): Rate limit `customStorage` configuration is either not implemented (at least I couldn't find it) or not being respected.
GiteaMirror commented 2026-03-13 07:35:59 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 3, 2024):

hey guys both issues should be fixed on 1.0.10! feel free to re-open if not

@Bekacru commented on GitHub (Dec 3, 2024): hey guys both issues should be fixed on 1.0.10! feel free to re-open if not
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?