github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8822] feat(passkey): allow for attestationType: "direct" #16483

New Issue
Open
opened 2026-04-13 10:32:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:32:19 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8822

State: open
Merged: No

Following what's described in #6371 (and old PR #2466), this PR allows for attestationType: "direct". This implies always requesting AAGUID from the passkey provider, since with "none" it sometimes defaulted to 00000000-0000-0000-0000-000000000000.

Summary by cubic

Add support for attestationType: "direct" in passkey registration while keeping the default "none". Added tests to ensure the default and forwarding behavior.

  • New Features
    • Add attestationType?: "none" | "direct" to PasskeyOptions.
    • Forward opts.attestationType to registration; fallback to "none".
    • Document attestationType in docs/plugins/passkey.mdx and add tests for default "none" and "direct".

Written for commit bd57d0475a. Summary will update on new commits.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8822 **State:** open **Merged:** No --- Following what's described in #6371 (and old PR #2466), this PR allows for `attestationType: "direct"`. This implies always requesting AAGUID from the passkey provider, since with `"none"` it sometimes defaulted to `00000000-0000-0000-0000-000000000000`. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Add support for `attestationType: "direct"` in passkey registration while keeping the default `"none"`. Added tests to ensure the default and forwarding behavior. - **New Features** - Add `attestationType?: "none" | "direct"` to `PasskeyOptions`. - Forward `opts.attestationType` to registration; fallback to `"none"`. - Document `attestationType` in `docs/plugins/passkey.mdx` and add tests for default `"none"` and `"direct"`. <sup>Written for commit bd57d0475aabf613b59de8ba22e44f9076c72f3c. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 10:32:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16483
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?