github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8708] fix: prevent revoked sessions from being restored via database fallback #16407

New Issue
Closed
opened 2026-04-13 10:30:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:30:52 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8708

State: closed
Merged: Yes

Note

preserveSessionInDatabase is intended for tracking, not authentication.

docs

https://better-auth.com/docs/concepts/session-management#preserving-sessions

When both preserveSessionInDatabase and storeSessionInDatabase are enabled, falling back to the database when a session is missing in secondary storage is not appropriate. It may improve resilience if secondary storage is down, but it goes beyond its intended purpose.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8708 **State:** closed **Merged:** Yes --- > [!NOTE] > ### `preserveSessionInDatabase` is intended for tracking, not authentication. > > <img width="913" height="447" alt="docs" src="https://github.com/user-attachments/assets/9df1801c-c751-406f-82ac-87c007db6b62" /> > > https://better-auth.com/docs/concepts/session-management#preserving-sessions When both `preserveSessionInDatabase` and `storeSessionInDatabase` are enabled, falling back to the database when a session is missing in secondary storage is not appropriate. It may improve resilience if secondary storage is down, but it goes beyond its intended purpose.
GiteaMirror added the pull-request label 2026-04-13 10:30:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16407
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?